From: Hans-Bernhard B. <br...@ph...> - 2004-03-25 14:46:57
|
On Thu, 25 Mar 2004, Hans-Bernhard Broeker wrote: > Aargh. The reason for that is of course, that do_arrow() will become > term->arrow(), so it *must* match the prototype for that in struct > TERMENTRY. OTOH, I don't see any real need to touch that argument of > do_arrow(). But in the meantime, I did find it. The head argument of term->arrow() is indeed used to pass a literal '2'. This really is bad, for at least two reasons. 1) It clearly breaks the entire idea behind having a TBOOLEAN. 2) That '2' should be a named constant. We don't want magic numbers. -- Hans-Bernhard Broeker (br...@ph...) Even if all the snow were burnt, ashes would remain. |