Re: NEW BUG: filled arrowheads not working

[Hans-Bernhard B. <br...@ph...>]

On Wed, 24 Mar 2004, Ethan Merritt wrote:

> Did this just break recently?  I don't recall getting these errors before.

I probably broke it on Tuesday, when I turned TBOOLEAN into an actual
C99-like bool, on those platforms that have this.  This was needed for the
benefit of Mac OS X, which ran into redefinition problems with bool.

> The problem is that curr_arrow_headfilled is a TBOOLEAN but then we find
> code like the following in term.c:
> 
> 	curr_arrow_headfilled = arrow_properties->head_filled
> 	...
> 	if (curr_arrow_headfilled == 2) {
> 		...

Which is, of course, plainly wrong.  Are we really getting this sloppy?

> I tried the simple fix of changing curr_arrow_headfilled to be an int
> rather than a TBOOLEAN, and similarly the last parameter to do_arrow(),
> but this just made things worse (hundreds of incompatible pointer
> warnings).

Aargh.  The reason for that is of course, that do_arrow() will become
term->arrow(), so it *must* match the prototype for that in struct
TERMENTRY.  OTOH, I don't see any real need to touch that argument of
do_arrow().  I'm checking in the change to curr_arrow_headfilled right
away.

-- 
Hans-Bernhard Broeker (br...@ph...)
Even if all the snow were burnt, ashes would remain.