Re: Somebody check my patch for SF bug 905651, please

[Petr M. <mi...@ph...>]

> I'm not convinced this can go into CVS before the 4.0 release.  It's a
> pretty serious bug, but I suspect the risk that my patch breaks something
> else is considerable.  I see three ways out of this dilemma:
>
> 1) Put it in CVS, then release yet another release candidate to the
> general public right away, to give this patch as much exposure as
> possible.
>
> 2) Some of us (Petr, most importantly...) test this rigorously before it
> goes in.  Then it goes into CVS for 4.0
>
> 3) Delay this patch until after the release.

It would be worth to submit the patch if it passes "demo/pm3d.dem" as well
... try to run the current and patched gnuplot versions with this file and
compare results. Currently, the new patch does not pass.


> I tried not to affect its operation in PM3D mode, but Petr or someone will
> have to check this.

> Petr: I you should do something about this FIXME comment of yours:
> (graph3d.c:2268 after this patch):
>
> 	if (*X_AXIS.label.text) {
> 	    /* label at xaxis_y + 1/4 of (xaxis_y-other_y) */
> #ifdef USE_GRID_LAYERS /* FIXME: still needed??? what for? */
> 	    if ((surface_rot_x <= 90 && BACKGRID != whichgrid) ||
> 		(surface_rot_x > 90 && FRONTGRID != whichgrid)) {
> #endif

With a simple
	set pm3d; set border 4095
	splot sin(x*y/4)/(x*y)

and rotation by mouse all around, it looks like your patch does sometimes
hide wrong bar of the border, e.g. for view: 146, 37, 1, 1 -- I think these
rot_x >=90 and <=90 conditions are just about this.


> Actually, since the tick labels are defined to always be outside the graph
> box, it shouldn't matter at all, as long as you make sure they're only
> output once.

I see these tics a major trouble here. Immediately the 1st three plots in
pm3d.dem look strange ... as well as all others. Even those splot with "pm3d
solid" are affected -- you see spurious tics without border's label. So
there is something out of proper order.

And "set grid back" is completely broken in the new patch.

Could you please fix it?

Petr