|
From: Daniel J S. <dan...@ie...> - 2003-11-04 22:09:39
|
Ethan Merritt wrote:
>On Tuesday 04 November 2003 13:39, Daniel J Sebald wrote:
>
>
>>So I would propose in the header file have two types of structures
>>
>>/* Contains a colour in RGB scheme.
>> Values of r, g and b are all in range [0;1] */
>>typedef struct {
>> double r, g, b;
>>} rgb1_color;
>>
>>
>
>We already have such a structure defined in color.h
>
Right. I was thinking of just adding a "1" to "rgb" for clarity.
It could be left as is.
>I'm all in favor code cleanups, up to a certain point.
>But this potentially touches a lot of code,
>
There are only about 20 occurrences in 4 files. Not too bad using
a "replace" edit function...
> so I think it
>should be bundled up into a separate patch so that
>it can be tested independent of your pixel/image stuff.
>
I agree.
Dan
|