|
From: Ethan M. <merritt@u.washington.edu> - 2003-11-04 21:49:49
|
On Tuesday 04 November 2003 13:39, Daniel J Sebald wrote:
> So I would propose in the header file have two types of structures
>
> /* Contains a colour in RGB scheme.
> Values of r, g and b are all in range [0;1] */
> typedef struct {
> double r, g, b;
> } rgb1_color;
We already have such a structure defined in color.h
> /* Contains a colour in RGB scheme.
> Values of r, g and b are all in range [0;255] */
> typedef struct {
> uchar r, g, b;
> } rgb255_color;
OK.
[snip description of passing the structure to subroutines,
rather than passing the individual r,g,b components]
> I sort of don't like large numbers of arguments in high
> level programming, only at the driver and assembly level.
I'm all in favor code cleanups, up to a certain point.
But this potentially touches a lot of code, so I think it
should be bundled up into a separate patch so that=20
it can be tested independent of your pixel/image stuff.
=09Ethan
--=20
Ethan A Merritt merritt@u.washington.edu
Biomolecular Structure Center Box 357742
University of Washington, Seattle, WA 98195
|