Re: pdfcairo terminal; seams between bars in the colorbox

[Ethan A M. <me...@uw...>]

On Sunday, 11 June 2023 20:44:31 PDT Dima Kogan wrote:

> Sorry for yet another email. I was dogfooding the patch, and found a
> minor bug. Sometimes term->image is not available, and the new colorbox
> implementation crashes in that case. I added a check to the top of the
> function, and it's good now:
> 
>   static void
>   draw_inside_colorbox_bitmap_smooth()
>   {
>       if(term->image == NULL)
>           return;
>   .....
> 
> I hit this with the "dumb" terminal. I think not rendering the colorbox
> at all in that case is fine. Are there other terminals where term->image
> is unavailable, but drawing discrete slices would still have produced
> good output?

It will take a while for me to work my way through your proposed changes.
But this much I can answer quickly -
Yes there are terminals that support smooth palette color but not term->image().
At a minimum they include
 block
 cgm
 emf
 fig
 sixeltek

	Ethan