Menu
▾
▴
Aw: What is the state of the Windows piping bug ?
|
From: Bastian M. <bma...@we...> - 2021-07-15 07:04:49
|
<html><head></head><body><div style="font-family: Verdana;font-size: 12.0px;"><div>Ethan,</div>
<div> </div>
<div>The Windows builds for 5.4.2 are just that - builds from the 5.4.2 source release.</div>
<div> </div>
<div>The piping bug #2412 has been confirmed fixed by the commit you mentioned.</div>
<div>It was introduced by an attempt to fix bug #2204 and I am waiting for feedback</div>
<div>on this one. We should only release 5.4.3 with this issue confirmed, too.</div>
<div>
<div> </div>
<div>
<div>In any case the Windows binary already now resolves some serious platform-specific</div>
<div>bugs, including a crash due to initialization errors, see #2223, #2227, #2286,</div>
<div>#2402. So the advisory on not using it at all is too strong in my opinion.</div>
<div> </div>
</div>
<div>Btw. please note that the "-os2" file is for OS/2, eComStation, ArcaOS and "_dj"</div>
<div>is a DOS (32bit) version.</div>
<div>
<div><br/>
Bastian</div>
<div> </div>
<div name="quote" style="margin:10px 5px 5px 10px; padding: 10px 0 10px 10px; border-left:2px solid #C3D9E5; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">
<div style="margin:0 0 10px 0;"><b>Gesendet:</b> Donnerstag, 15. Juli 2021 um 06:30 Uhr<br/>
<b>Von:</b> "Ethan A Merritt" <me...@uw...><br/>
<b>An:</b> gnu...@li...<br/>
<b>Cc:</b> "Bastian Märkisch" <bma...@we...><br/>
<b>Betreff:</b> What is the state of the Windows piping bug ?</div>
<div name="quoted-content"><!--p, li {
}
-->
<div style="font-family: "DejaVu Sans";font-size: 10.0pt;font-weight: 400;font-style: normal;">
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">Bastian:</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">Your fix for the WIndows piping bug went into the stable branch on 10 July.</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">This was after the nominal release date for version 5.4.2</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">The Windows binaries on SourceForge are timestamped that same day.</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">gp542-os2-emx.zip 2021-07-11 3.4 MB</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">gp541-win64-mingw.7z 2021-07-10 28.8 MB</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">gp542_dj.zip 2021-07-10 4.0 MB</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">gp542-win64-mingw.exe 2021-07-10 31.7 MB</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">Is the fix included in these binaries or not?</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">If it is then the README on the download site should say so</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">(right now it advises not to use the Windows binaries)</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">If it is not - should we put out a quick version 5.4.3 for Windows?</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"> </p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;">Commit a501a67a</p>
<p style="margin-top: 0.0px;margin-bottom: 0.0px;margin-left: 0.0px;margin-right: 0.0px;text-indent: 0.0px;"><span style="font-family: monospace;color: rgb(0,0,0);background-color: rgb(255,255,255);">Author: Bastian Maerkisch <bma...@we...> </span><br/>
<span style="font-family: monospace;">Date: Sat Jul 10 20:41:40 2021 +0200<br/>
<br/>
Fix handling Window messages for input from a pipe<br/>
<br/>
As pointed out in bug report #2412, MsgWaitForMultipleObjects() does not work<br/>
as expected if the input comes from a pipe. This reverts 651af6267b<br/>
"Wait for pipe events without additional thread", which aimed at speeding-up<br/>
piped input, Instead of recreating the input thread for every single<br/>
character, we now keep the thread alive and signal an event object on new<br/>
input. This should still be much faster.<br/>
<br/>
Bugs #2412 and #2204</span><br/>
</p>
</div>
</div>
</div>
</div>
</div></div></body></html>
|
