Re: Bug in 5.4.rc2

[Ethan A M. <me...@uw...>]

On Friday, 26 June 2020 12:42:04 PDT Dima Kogan wrote:
> The simplest patch is this:
> 
> diff --git a/src/plot2d.c b/src/plot2d.c
> index c81fc2344..a8e598359 100644
> --- a/src/plot2d.c
> +++ b/src/plot2d.c
> @@ -1097,7 +1097,7 @@ get_data(struct curve_points *current_plot)
>  	    coordval major_axis = (j >= 3) ? fabs(v[2]) : 0.0;
>  	    coordval minor_axis = (j >= 4) ? fabs(v[3]) : (j >= 3) ? fabs(v[2]) : 0.0;
>  	    coordval orientation = (j >= 5) ? v[4] : 0.0;
> -	    coordval flag = (major_axis > 0 && minor_axis > 0) ? 0.0 : DEFAULT_RADIUS;
> +	    coordval flag = (j >= 3) ? 0.0 : DEFAULT_RADIUS;
> 
>  	    if (j == 2)	/* FIXME: why not also for j == 3 or 4? */
>  		orientation = default_ellipse.o.ellipse.orientation;
> 
> I.e. we use the default ellipse style only if no axis sizes are given at
> all. If anything is given, we use it. Thoughts?

I think I like the other option better:
	zero means zero
	negative means use default from "set style ellipse"

But I also think you can achieve what you want without changing the code
at all, by setting the default ellipse to have 0 size.
Right?

I'm working on something else at the moment.
I'll get back to this afterwards.

	Ethan