Re: Bug in 5.4.rc2

[Dima K. <gn...@di...>]

Ethan A Merritt <me...@uw...> writes:

> On Friday, 26 June 2020 02:21:58 PDT Dima Kogan wrote:
>> Ethan A Merritt <me...@uw...> writes:
>>
>> > Sounds like your plot wants to use "with ellipses".
>>
>> OK, I'm using ellipses now. It does what I want. I just hit a corner
>> case, however that did a surprising thing. The corner case is this:
>>
>>   plot '-' notitle with ellipses
>>   0 0 0 0
>>
>> <snip>
>>
>> Thus here I would expect nothing
>> drawn, or maybe just a single dot drawn. Instead it draws an ellipse of
>> some arbitrary size, independent of the zoom level: it's an abstract
>> symbol.
>
> I can see why you would expect the size to go to zero or a dot if
> the axis length values reach 0.  That would be reasonable, but currently
> it interprets that as a request to use the default properties set by
>       set style ellipse ...
> which also seem reasonable.  Did it do something else?
>
>> Proposal: ellipses with axis lengths >= 0 are not abstract symbols, and
>> are drawn as the data dictates. axis lengths < 0 may be rendered as
>> symbols.
>>
>> Reasonable?
>
> Currently the code uses the absolute value of the axis lengths,
> so negative values have no special meaning.

Right. But that's an implementation detail. The data could potentially
contain size-0 ellipses, and they should be drawn as size-0 ellipses. If
we really want to have a mode where the default properties are used
instead, they should be accessed with size<0. But I don't actually think
that's useful: if the user is specifying an ellipse size, we should use
it.

Want a patch?