Re: Default fillstyle for 'set rectangle' is slightly wrong

[Ethan A M. <me...@uw...>]

On Saturday, 2 May 2020 15:01:57 PDT Dima Kogan wrote:
> Hi. Thanks for the context.
> 
> I don't entirely follow the explanation, though. You're saying that "set
> style fill" kicks in when objects come from the plot and "set style
> rectangle" kicks in when objects come from "set object rectangle"?

Yes.

> My general feeling is that breaking backwards compatibility should be
> avoided at all costs, and we probably should leave this the way it is.
> After all, it has been this way, and you hear complaints very rarely.
> 
> One thing we SHOULD change is the docs. The impetus for this thread was
> that I was apparently looking at the wrong part of the docs, which told
> me the wrong thing. 

The information _is_ in there, but I can try to make it clearer. 

> If the interpretation above is correct, then "help
> set style rectangle" can say
> 
>   The default values correspond to solid fill with the background color
>   and a black border. Note that this default applies to rectangles
>   created with "set object". Rectangles from data are controlled by "set
>   style fill", and are empty by default.
> 
> Or something like that. Is that reasonable?

It already does say something like that, doesn't it?
The current text (version 5.2.8) reads

 Rectangles defined with the `set object` command can have individual styles.
 However, if the object is not assigned a private style then it inherits a
 default that is taken from the `set style rectangle` command.
 [syntax and examples snipped]
 The default values correspond to solid fill with the background color and a
 black border.

The place where I can see it is a bit unclear is that "help set style fill"
only says "see also 'set style rectangle'", which isn't much of a warning.

I have now expanded that for 5.4 to read:

   Note that there is a separate default fill style for rectangle objects.
   See `set style rectangle`.

Do you think that is OK, or is there something more or some additional
place it should be expanded?

	Ethan