From: Henri M. <hen...@gm...> - 2020-01-31 06:08:55
|
On 1/31/20 9:49 AM, Henri Menke wrote: > On 1/31/20 8:46 AM, Ethan A Merritt wrote: >> On Wednesday, 29 January 2020 20:23:28 PST Henri Menke wrote: >>> Dear list, >>> >>> In merge request #12 I propose the addition of the XDG base directory >>> specification for configuration file paths. >>> >>> https://sourceforge.net/p/gnuplot/gnuplot-main/merge-requests/12/ >>> >>> There is already some discussion on the ticket. It seems that the >>> overall opinion is in favor of this addition. Is this correct? If that >>> is the case, could you please review the code? After that I will write >>> some words in the docs and we should be good to go. >> >> I notice that the filename is generated by a call to wordexp(). >> This is in POSIX-2001 but is not in the c99 standard, right? >> The gnu docs say >> "This function is missing on some platforms: Mac OS X 10.3, OpenBSD 3.8, >> Minix 3.1.8, IRIX 5.3, Cygwin 1.5.x, mingw, MSVC 14, Interix 3.5, BeOS, >> Android 9.0." >> >> We have just barely got the gnuplot code base up to c99, so anything >> beyond that should be protected by a feature test. Is there an >> autoconf macro for this? >> >> If the purpose is just to handle tilde expansion, can this dependence >> be removed by replacing it with a call to gp_expand_tilde()? > > You're right, wordexp is a POSIX function. I will revise the code to > use gp_expand_tilde instead. I've updated the merge request and wrote some docs. > Cheers, Henri > >> Ethan >> >> >> >> |