From: sfeam <sf...@us...> - 2018-04-28 05:20:45
|
On Friday, 27 April 2018 13:18:50 Dima Kogan wrote: > Ethan A Merritt <sf...@us...> writes: > > >> Yeah. I think the auto-writeback logic proposed earlier is the more > >> complete way to do this. > > A crude prototype patch is attached. It unconditionally saves the > writeback before each plot, and unconditionally restores it before each > refresh (not replot). Works for the test case here. With a bit of > extending, I'd like to see something like this be included. Looks promising! I have applied your patch, lightly edited, to the development version and removed the code it replaces. The change fixes a problem with "refresh" in 3D plots that I was not aware of. I'd like to see this change tested in the development version for one cycle before applying it to the stable series, because it does change the use of the axis writeback flag and so has in theory a potential to break existing scripts that use "set xrange nowriteback". That was always a very obscure option so there may well not be any such scripts. While testing I managed to trigger a bad state after an "unzoom" operation of a plot with logscale axes. But then I couldn't reproduce it so I can't say for sure that it was really the new code at fault. It's hard to automate testing of zoom/unzoom and window redraw operations. If no one complains about the changed status of the writeback flag there is one further step of simplification possible by setting that flag in the default axis structures for x/y/etc rather than setting it all over again in every plot and splot command. Ethan |