gnuplot-beta

gnuplot_date[] in timestamp.h is empty building source from git in case of build directory being special

[Tatsuro M. <tma...@ya...>]

The previous thread


gnuplot_date[] in timestamp.h is empty after "make" in building source from git

https://sourceforge.net/p/gnuplot/mailman/gnuplot-beta/thread/165023.485.qm%40web103109.mail.kks.yahoo.co.jp/#msg36223866

is not correct.
case 1:

cd (source tree)

./prepare

./configure
make

give correct gnuplot_date[] in timestamp.h


case 2:

cd (source tree)

./prepare

mkdir .build
cd .build

../configure
make

also give correct gnuplot_date[] in timestamp.h

Assuming that source tree directory name is gnuplot-main

case

cd (source tree)

./prepare
cd ..
mkdir .build
cd ,build
../gnuplot-main/configure
make

give empty gnuplot_date[] in timestamp.h


In case of cvs source, I could get correct gnuplot_date[] in timestamp.h
even in case 3.

What is happening?

Tatsuro


case 3

Re: gnuplot_date[] in timestamp.h is empty building source from git in case of build directory being special

[Dima K. <gn...@di...>]

Tatsuro MATSUOKA <tma...@ya...> writes:

> case
>
> cd (source tree)
>
> ./prepare
> cd ..
> mkdir .build
> cd ,build
> ../gnuplot-main/configure
> make
>
> give empty gnuplot_date[] in timestamp.h

OK, that makes sense. This patch will fix it:

 diff --git a/src/Makefile.am b/src/Makefile.am
 index 9c57550f7..1ce9735a4 100644
 --- a/src/Makefile.am
 +++ b/src/Makefile.am
 @@ -110,7 +110,7 @@ timestamp.h: $(top_srcdir)/.git/${git_current} Makefile
         @echo Making $@
         @echo "#ifndef GNUPLOT_TIMEBASE_H_INCLUDED" >$@t
         @echo "#define GNUPLOT_TIMEBASE_H_INCLUDED" >>$@t
 -	@echo "const char gnuplot_date[] = \"`git log -1 --format=%ci | cut -b-11`\";" >>$@t
 +	@echo "const char gnuplot_date[] = \"`git --git-dir '$(top_srcdir)/.git' log -1 --format=%ci | cut -b-11`\";" >>$@t
         @echo "#endif /* GNUPLOT_TIMEBASE_H_INCLUDED */" >> $@t
         @if cmp -s $@ $@t; then rm -f $@t; else mv $@t $@; fi

If the 

Re: gnuplot_date[] in timestamp.h is empty building source from git in case of build directory being special

[Tatsuro M. <tma...@ya...>]

Commit  [ce2464] modify recipe for regenerating timestamp.h during build from git source
by Mojca solves the issue.

Thanks!

Tatsuro



----- Original Message -----
> From: Dima Kogan <gn...@di...>
> To: gnu...@li...
> Cc: 
> Date: 2018/2/14, Wed 04:32
> Subject: Re: gnuplot_date[] in timestamp.h is empty building source from git in case of build directory being special
> 
>T atsuro MATSUOKA <tma...@ya...> writes:
> 
>>  case
>> 
>>  cd (source tree)
>> 
>>  ./prepare
>>  cd ..
>>  mkdir .build
>>  cd ,build
>>  ../gnuplot-main/configure
>>  make
>> 
>>  give empty gnuplot_date[] in timestamp.h
> 
> OK, that makes sense. This patch will fix it:
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index 9c57550f7..1ce9735a4 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -110,7 +110,7 @@ timestamp.h: $(top_srcdir)/.git/${git_current} Makefile
>          @echo Making $@
>          @echo "#ifndef GNUPLOT_TIMEBASE_H_INCLUDED" >$@t
>          @echo "#define GNUPLOT_TIMEBASE_H_INCLUDED" >>$@t
> -    @echo "const char gnuplot_date[] = \"`git log -1 --format=%ci 
> | cut -b-11`\";" >>$@t
> +    @echo "const char gnuplot_date[] = \"`git --git-dir 
> '$(top_srcdir)/.git' log -1 --format=%ci | cut -b-11`\";" 
>>> $@t
>          @echo "#endif /* GNUPLOT_TIMEBASE_H_INCLUDED */" >> $@t
>          @if cmp -s $@ $@t; then rm -f $@t; else mv $@t $@; fi
> 
> If the 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> Membership management via: 
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
>