Menu
▾
▴
gnuplot-beta
|
From: Dima K. <gn...@di...> - 2014-04-28 20:30:27
|
Hi. The default line width appears to have been affected in a recent commit: https://github.com/gnuplot/gnuplot/commit/b6c8dbfc63387be9e0c84d0d7b9ba6f480e5da8b The commit notes don't say anything about it, so I'm wondering if this change wasn't intentional. Is nobody else seeing this? dima |
|
From: Ethan A M. <sf...@us...> - 2014-04-28 21:08:44
|
On Monday, 28 April, 2014 13:30:18 Dima Kogan wrote: > Hi. > > The default line width appears to have been affected in a recent commit: > > https://github.com/gnuplot/gnuplot/commit/b6c8dbfc63387be9e0c84d0d7b9ba6f480e5da8b > > The commit notes don't say anything about it, so I'm wondering if this > change wasn't intentional. Is nobody else seeing this? Do you mean lines in the "test" command? Which terminal? > dima |
|
From: Dima K. <gn...@di...> - 2014-04-28 21:11:10
|
Ethan A Merritt <sf...@us...> writes: > On Monday, 28 April, 2014 13:30:18 Dima Kogan wrote: >> Hi. >> >> The default line width appears to have been affected in a recent commit: >> >> https://github.com/gnuplot/gnuplot/commit/b6c8dbfc63387be9e0c84d0d7b9ba6f480e5da8b >> >> The commit notes don't say anything about it, so I'm wondering if this >> change wasn't intentional. Is nobody else seeing this? > > Do you mean lines in the "test" command? Which terminal? I just ran a few more tests. Only the x11 terminal appears to be affected. This explains why nobody complained yet. To reproduce, plot anything 'with lines' in x11. Or "plot x". dima |
|
From: Ethan A M. <merritt@u.washington.edu> - 2014-04-28 21:36:20
|
On Monday, 28 April, 2014 14:10:59 Dima Kogan wrote: > Ethan A Merritt <sf...@us...> writes: > > > On Monday, 28 April, 2014 13:30:18 Dima Kogan wrote: > >> Hi. > >> > >> The default line width appears to have been affected in a recent commit: > >> > >> https://github.com/gnuplot/gnuplot/commit/b6c8dbfc63387be9e0c84d0d7b9ba6f480e5da8b > >> > >> The commit notes don't say anything about it, so I'm wondering if this > >> change wasn't intentional. Is nobody else seeing this? > > > > Do you mean lines in the "test" command? Which terminal? > > I just ran a few more tests. Only the x11 terminal appears to be > affected. This explains why nobody complained yet. To reproduce, plot > anything 'with lines' in x11. Or "plot x". I can see only one relevant change. The linetype selected for the line samples in "test" changed from LT_AXIS to LT_SOLID. The default X11 settings for those are ! Default line widths gnuplot*axisWidth: 0 gnuplot*line1Width: 1 I'm not entirely clear whether width 0 is expected to be narrower than width 1, but it's believable. But that would only affect the "test" command. I don't see anything in that patchset that would affect normal plotting, so that part remains unexplained. I find it odd that it would hit only the X11 terminal. I guess we'll find out if people report anything similar for other terminals. Ethan |
|
From: sfeam <sf...@us...> - 2014-04-29 03:16:40
|
On Monday, 28 April 2014 02:34:01 PM Ethan A Merritt wrote: > On Monday, 28 April, 2014 14:10:59 Dima Kogan wrote: > > Ethan A Merritt <sf...@us...> writes: > > > > > On Monday, 28 April, 2014 13:30:18 Dima Kogan wrote: > > >> Hi. > > >> > > >> The default line width appears to have been affected in a recent commit: > > >> > > >> https://github.com/gnuplot/gnuplot/commit/b6c8dbfc63387be9e0c84d0d7b9ba6f480e5da8b > > >> > > >> The commit notes don't say anything about it, so I'm wondering if this > > >> change wasn't intentional. Is nobody else seeing this? > > > > > > Do you mean lines in the "test" command? Which terminal? > > > > I just ran a few more tests. Only the x11 terminal appears to be > > affected. This explains why nobody complained yet. To reproduce, plot > > anything 'with lines' in x11. Or "plot x". Here is what is going on. 1) For a long time gnuplot has used the special linetype -1 to indicate a solid black line. This has been a convenient way to guarantee getting a black line even if the normal terminal color sequence does not include black. Most places in the code refer to this linetype as LT_BLACK. 2) Since lt -1 was also guaranteed to be a solid line whatever the terminal dash pattern sequence, it seemed logical to also special case this linetype as LT_SOLID for the purpose of supporting dashtypes. So far so good. 3) The glitch is that some of the oldest gnuplot terminals apparently treat lt -1 as a solid black _double thickness_ line. This is true at least for x11 and postscript. I have not yet checked all the others. So in revising the code to support dashtypes, all the solid lines started being drawn with LT_SOLID, which for x11 and postscript is for some reason drawn double thickness. I see two possible fixes. 1) Change LT_SOLID to some other value. The obvious value would be linetype 1. But this would mean you can never set a non-solid dashpattern for linetype 1, so I don't like this idea. 2) Change x11 so that lt -1 is not drawn double thickness by default. I don't see a problem there. What about postscript? The postscript code really does treat this linetype differently, so there might be side effects from changing it even aside from all those old postscript generating gnuplot scripts out there that were written when lt -1 produced a thicker line. On the other hand, unlike the x11 case the factor of two in the default lt -1 linewidth does not affect any other linetypes or linewidths. So we could just leave it I'm leaning toward fix #2, either with or without making a change to postscript also. Ethan |
|
From: Dmitri A. S. <das...@gm...> - 2014-04-28 21:51:50
|
On Mon, Apr 28, 2014 at 4:34 PM, Ethan A Merritt <merritt@u.washington.edu>wrote: > > ! Default line widths > gnuplot*axisWidth: 0 > gnuplot*line1Width: 1 > > I'm not entirely clear whether width 0 is expected to be narrower than > width 1, but it's believable. But that would only affect the "test" > command. > It appears to me that width 0 on x11 means 1 pixel, width 1 2 pixels, etc... So in the current version ( Version 5.0 patchlevel alpha last modified 2014-04-28 ) plot sin(x) lw 5 looks the same as plot sin(x) lw 10 on Version 4.6 patchlevel 5 last modified February 2014 Except the colors are also different -- why did this changed? Dmitri. -- |
|
From: Ethan A M. <merritt@u.washington.edu> - 2014-04-28 22:08:36
|
On Monday, 28 April, 2014 16:51:44 Dmitri A. Sergatskov wrote:
> On Mon, Apr 28, 2014 at 4:34 PM, Ethan A Merritt
> <merritt@u.washington.edu>wrote:
>
> >
> > ! Default line widths
> > gnuplot*axisWidth: 0
> > gnuplot*line1Width: 1
> >
> > I'm not entirely clear whether width 0 is expected to be narrower than
> > width 1, but it's believable. But that would only affect the "test"
> > command.
> >
>
>
> It appears to me that width 0 on x11 means 1 pixel, width 1 2 pixels,
> etc...
> So in the current version (
> Version 5.0 patchlevel alpha last modified 2014-04-28
> )
>
> plot sin(x) lw 5
>
> looks the same as
>
> plot sin(x) lw 10
> on
> Version 4.6 patchlevel 5 last modified February 2014
I guess that the following command from any terminal in your current
session will restore the previous behaviour:
echo "gnuplot*borderWidth: 1" | xrdb -merge
But I do not understand why this one linetype is now affecting all
the others. There has been no change to the code in either x11.trm
or gplt_x11.c, so this must be a case of a slightly different command
sequence from the core code revealing a bug that may have been
there for a long time. Can anyone spot anything relevant?
Ethan
>
> Except the colors are also different -- why did this changed?
>
> Dmitri.
>
|
