|
From: Tatsuro M. <tma...@ya...> - 2015-03-30 04:37:47
|
Hello I have checked out the latest cvs snapshot of gnuplot (ChageLog 2015-03-29) In windows build (make all), GNUPLOT_LIB=../../docs/psdoc GNUPLOT_PS_DIR=../../term/PostScript gnuplot.exe ps_symbols.gpi set terminal postscript lw 1.5; set output 'ps_symbols.ps' ^ "ps_symbols.gpi", line 2: unrecognized option Makefile:789: recipe for target 'ps_symbols.pdf' failed make[1]: *** [ps_symbols.pdf] Error 1 make[1]: Leaving directory '/e/usr/Tatsu/mingw32work_490/gnuplot/gnuplotcvs/gnuplot/config/mingw' Makefile:465: recipe for target 'docs' failed make: *** [docs] Error 2 set terminal postscript lw 1.5; set output 'ps_symbols.ps' ^ "ps_symbols.gpi", line 2: unrecognized option I do not understand why the line 2 gives error. I have never experienced such an error during "make all" What is happening? Regards Tatsuro |
|
From: Tatsuro M. <tma...@ya...> - 2015-03-30 06:30:19
|
----- Original Message ----- > From: Tatsuro MATSUOKA > To: gnuplot-beta > Cc: > Date: 2015/3/30, Mon 13:37 > Subject: "ps_symbols.gpi", line 2: unrecognized option during make ps_symbols.ps > > Hello > > I have checked out the latest cvs snapshot of gnuplot (ChageLog 2015-03-29) > > In windows build (make all), > > > GNUPLOT_LIB=../../docs/psdoc GNUPLOT_PS_DIR=../../term/PostScript gnuplot.exe > ps_symbols.gpi > > set terminal postscript lw 1.5; set output 'ps_symbols.ps' > ^ > "ps_symbols.gpi", line 2: unrecognized option > > Makefile:789: recipe for target 'ps_symbols.pdf' failed > make[1]: *** [ps_symbols.pdf] Error 1 > make[1]: Leaving directory > '/e/usr/Tatsu/mingw32work_490/gnuplot/gnuplotcvs/gnuplot/config/mingw' > Makefile:465: recipe for target 'docs' failed > make: *** [docs] Error 2 > > > set terminal postscript lw 1.5; set output 'ps_symbols.ps' > ^ > "ps_symbols.gpi", line 2: unrecognized option > > I do not understand why the line 2 gives error. > > I have never experienced such an error during "make all" > What is happening? > > Regards > > Tatsuro > From gnuplot prompt; Version 5.1 patchlevel 0 last modified 2015-03-29 gnuplot> set terminal postscript lw 1.5; set output 'ps_symbols.ps' Terminal type set to 'postscript' Options are 'landscape enhanced defaultplex \ leveldefault monochrome colortext \ dashlength 1.0 linewidth 1.5 butt noclip \ nobackground \ palfuncparam 2000,0.003 \ "Helvetica" 14 fontscale 1.0 ' ^ unrecognized option ???? Of course gnuplot> set terminal postscript lw 1.5 gnuplot> set output 'ps_symbols.ps' is OK. What happens in the latest change? Tasturo |
|
From: Tatsuro M. <tma...@ya...> - 2015-03-30 06:48:51
|
> From: Tatsuro MATSUOKA > To: tma...@ya...; gnuplot-beta > Cc: > Date: 2015/3/30, Mon 15:30 > Subject: Re: "ps_symbols.gpi", line 2: unrecognized option during make ps_symbols.ps > > >> From: Tatsuro MATSUOKA >> To: gnuplot-beta >> Cc: >> Date: 2015/3/30, Mon 13:37 >> Subject: "ps_symbols.gpi", line 2: unrecognized option during > make ps_symbols.ps >> >> Hello >> >> I have checked out the latest cvs snapshot of gnuplot (ChageLog > 2015-03-29) >> >> In windows build (make all), >> >> >> GNUPLOT_LIB=../../docs/psdoc GNUPLOT_PS_DIR=../../term/PostScript > gnuplot.exe >> ps_symbols.gpi >> >> set terminal postscript lw 1.5; set output 'ps_symbols.ps' >> ^ >> "ps_symbols.gpi", line 2: unrecognized option >> >> Makefile:789: recipe for target 'ps_symbols.pdf' failed >> make[1]: *** [ps_symbols.pdf] Error 1 >> make[1]: Leaving directory >> > '/e/usr/Tatsu/mingw32work_490/gnuplot/gnuplotcvs/gnuplot/config/mingw' >> Makefile:465: recipe for target 'docs' failed >> make: *** [docs] Error 2 >> >> >> set terminal postscript lw 1.5; set output 'ps_symbols.ps' >> ^ >> "ps_symbols.gpi", line 2: unrecognized option >> >> I do not understand why the line 2 gives error. >> >> I have never experienced such an error during "make all" >> What is happening? >> >> Regards >> >> Tatsuro >> > From gnuplot prompt; > > Version 5.1 patchlevel 0 last modified 2015-03-29 > > > gnuplot> set terminal postscript lw 1.5; set output 'ps_symbols.ps' > Terminal type set to 'postscript' > Options are 'landscape enhanced defaultplex \ > leveldefault monochrome colortext \ > dashlength 1.0 linewidth 1.5 butt noclip \ > nobackground \ > palfuncparam 2000,0.003 \ > "Helvetica" 14 fontscale 1.0 ' > ^ > unrecognized option > ???? > > Of course > > gnuplot> set terminal postscript lw 1.5 > gnuplot> set output 'ps_symbols.ps' > > > is OK. > > What happens in the latest change? > > Tasturo The same phenomenon occurs on gnuplot on Ubuntu 14.04 LTS. gnuplot> set terminal postscript lw 1.5; set output 'ps_symbols.ps' Terminal type set to 'postscript' Options are 'landscape enhanced defaultplex \ leveldefault monochrome colortext \ dashlength 1.0 linewidth 1.5 butt noclip \ nobackground \ palfuncparam 2000,0.003 \ "Helvetica" 14 fontscale 1.0 ' ^ unrecognized option gnuplot> The above seem to be platform independent. Tatsuro |
|
From: sfeam <sf...@us...> - 2015-03-30 15:40:12
|
On Monday, 30 March 2015 03:48:41 PM Tatsuro MATSUOKA wrote: > The same phenomenon occurs on gnuplot on Ubuntu 14.04 LTS. > gnuplot> set terminal postscript lw 1.5; set output 'ps_symbols.ps' > Terminal type set to 'postscript' > Options are 'landscape enhanced defaultplex \ > leveldefault monochrome colortext \ > dashlength 1.0 linewidth 1.5 butt noclip \ > nobackground \ > palfuncparam 2000,0.003 \ > "Helvetica" 14 fontscale 1.0 ' > ^ > unrecognized option > > gnuplot> > > The above seem to be platform independent. > > Tatsuro Sorry for the error. It is fixed now. This is an example of a tyoe of programming error (failure to check for end of command line) that is not exercised or caught by running "make check". Does anyone have suggestions about how to add more stringent tests for debugging program changes? Ethan |
|
From: Tatsuro M. <tma...@ya...> - 2015-03-31 01:19:58
|
> From: sfeam > To: gnuplot-beta; Tatsuro MATSUOKA > Cc: > Date: 2015/3/31, Tue 00:38 > Subject: Re: set terminal postscript lw 1.5; set output 'ps_symbols.ps' causes an error (was Re: "ps_symbols.gpi", line 2: unrecognized option during make ps_symbols.ps) > > On Monday, 30 March 2015 03:48:41 PM Tatsuro MATSUOKA wrote: > >> The same phenomenon occurs on gnuplot on Ubuntu 14.04 LTS. >> gnuplot> set terminal postscript lw 1.5; set output > 'ps_symbols.ps' >> Terminal type set to 'postscript' >> Options are 'landscape enhanced defaultplex \ >> leveldefault monochrome colortext \ >> dashlength 1.0 linewidth 1.5 butt noclip \ >> nobackground \ >> palfuncparam 2000,0.003 \ >> "Helvetica" 14 fontscale 1.0 ' >> ^ >> unrecognized option >> >> gnuplot> >> >> The above seem to be platform independent. >> >> Tatsuro > > Sorry for the error. It is fixed now. > I have confirmed the fix and update the cvs version windows cygwin binary on my site. Thanks > This is an example of a tyoe of programming error (failure to > check for end of command line) that is not exercised or caught > by running "make check". Does anyone have suggestions about > how to add more stringent tests for debugging program changes? > > Ethan For me, I do not have any good idea for this matter. The CVS version is open to the people who would like to use the latest feature. In the process of build or using gnuplot, they will notice a flaw or flaws and will do feedback. The feedback will help to the bug fix introducing the new features. When I notice the flaw like this time, I will report as soon as possible. Tatsuro |
|
From: <pl...@pi...> - 2015-03-30 20:36:01
|
On 03/30/15 17:38, sfeam wrote: > On Monday, 30 March 2015 03:48:41 PM Tatsuro MATSUOKA wrote: > >> The same phenomenon occurs on gnuplot on Ubuntu 14.04 LTS. >> gnuplot> set terminal postscript lw 1.5; set output 'ps_symbols.ps' >> Terminal type set to 'postscript' >> Options are 'landscape enhanced defaultplex \ >> leveldefault monochrome colortext \ >> dashlength 1.0 linewidth 1.5 butt noclip \ >> nobackground \ >> palfuncparam 2000,0.003 \ >> "Helvetica" 14 fontscale 1.0 ' >> ^ >> unrecognized option >> >> gnuplot> >> >> The above seem to be platform independent. >> >> Tatsuro > > Sorry for the error. It is fixed now. > > This is an example of a tyoe of programming error (failure to > check for end of command line) that is not exercised or caught > by running "make check". Does anyone have suggestions about > how to add more stringent tests for debugging program changes? > > Ethan > 'unrecognized option' suggests it was still parsing when,indeedn, it should have been. Where is the end of line that it failed to find? I don't see what you are hoping to catch, or what the root cause of this bug was. Peter. |
|
From: Ethan A M. <sf...@us...> - 2015-03-30 21:43:02
|
On Monday, 30 March, 2015 21:21:04 pl...@pi... wrote: > On 03/30/15 17:38, sfeam wrote: > > On Monday, 30 March 2015 03:48:41 PM Tatsuro MATSUOKA wrote: > > > >> The same phenomenon occurs on gnuplot on Ubuntu 14.04 LTS. > >> gnuplot> set terminal postscript lw 1.5; set output 'ps_symbols.ps' > >> Terminal type set to 'postscript' > >> Options are 'landscape enhanced defaultplex \ > >> leveldefault monochrome colortext \ > >> dashlength 1.0 linewidth 1.5 butt noclip \ > >> nobackground \ > >> palfuncparam 2000,0.003 \ > >> "Helvetica" 14 fontscale 1.0 ' > >> ^ > >> unrecognized option > >> > >> gnuplot> > >> > >> The above seem to be platform independent. > >> > >> Tatsuro > > > > Sorry for the error. It is fixed now. > > > > This is an example of a tyoe of programming error (failure to > > check for end of command line) that is not exercised or caught > > by running "make check". Does anyone have suggestions about > > how to add more stringent tests for debugging program changes? > > > > Ethan > > > > 'unrecognized option' suggests it was still parsing when,indeedn, it > should have been. Where is the end of line that it failed to find? > > I don't see what you are hoping to catch, or what the root cause of > this bug was. The error was that it incremented the current token index, c_token, past the semicolor. Parsing is obviously supposed to stop and restart after the semicolor, but the check has to be made explicitly using if (END_OF_COMMAND) ... In this case I forget to add that check, so the parser tried to interpret the subsequent "set output ..." as if it were part of the previous command. A while back I caught a dozen or so examples of this same error by manually editing the demo collection to add " ; junk_command=0 " at the end of every line of each demo. That had the effect of testing whether the implementation of every command used by the demos correctly checked for end of command and therefore did not over-run the semicolon. I guess what I'd like is a more generalized "command fuzzer", to test whether incorrect input is correctly caught and reported rather than triggering a segfault or other unpleasant behaviour. Ethan |