|
From: Daniel J S. <dan...@ie...> - 2012-12-21 02:55:46
|
Hi Folks, Someone on the Octave list brought up an issue with requiring "set termoption dashed" to get dashed lines. The conclusion was that most terminals appear to work except X11. I thought Ethan had added dashed line support to X11 terminal some time ago. Well, that got me to checking into the X11 terminal with the latest gnuplot CVS code. I found that the "test" screen is failing. As far back as September 26: cvs -z3 -d:pserver:ano...@gn...:/cvsroot/gnuplot co -D 2012-09-26 -P gnuplot things are beginning to not look correct. On that date the height of the test page is not correct within the X11 window. By October 04: cvs -z3 -d:pserver:ano...@gn...:/cvsroot/gnuplot co -D 2012-10-04 -P gnuplot rather than lines on the right side there are all kinds of filled polygons and strange lines randomly placed on the screen. As for the aspect ratio, I would guess that maybe this change: 2012-09-25 D.K. <> * src/gplt_x11.c src/mouse.c (do_event) term/x11.trm: Feed back the x11 window size from gnuplot_x11 to gnuplot so that the coordinates can be rescaled to maintain the correct aspect ratio. This allows correct functioning of commands like 'set size square' and 'set view equal xyz' in an interactive x11 output window. led to this. Perhaps something is overlooked in the test page. Maybe it used to have some bad compensation from the past that is no longer relevant after the fix of the aspect ratio code. As best I can figure for the random polygons, maybe this one: 2012-09-28 D.K. <> * src/gplt_x11.c src/gplt_x11.h: Remove dead code. * src/gplt_x11.c term/x11.trm: Modify format statements used to send commands from x11.trm to gnuplot_x11. Before most integers were sent using "%04d", now " %d". This prevents overflow for coordinate > 9999. The extra byte required for a 4-digit coordinate is compensated by fewer bytes needed for small integers like linetype. * src/gplt_x11.c src/gplt_x11.h: Adjust point size to accommodate changes in window size. Dan |
|
From: sfeam (E. Merritt) <eam...@gm...> - 2012-12-21 04:08:32
|
On Thursday, 20 December 2012, Daniel J Sebald wrote: > Hi Folks, > > Someone on the Octave list brought up an issue with requiring "set > termoption dashed" to get dashed lines. The conclusion was that most > terminals appear to work except X11. I thought Ethan had added dashed > line support to X11 terminal some time ago. The problem is that x11 line types are controlled through the XResource mechanism rather than from the command line. You can do "set term x11 dash", but it only produces the expected result if you have defined the dashed line types in .XDefaults or another resource file. This is all documented extensively. > Well, that got me to checking into the X11 terminal with the latest > gnuplot CVS code. I found that the "test" screen is failing. As far > back as September 26: > > cvs -z3 > -d:pserver:ano...@gn...:/cvsroot/gnuplot co -D > 2012-09-26 -P gnuplot > > things are beginning to not look correct. On that date the height of > the test page is not correct within the X11 window. By October 04: That was around the time that Dima Kogan's updates to x11 started to go in. They introduce changes in the protocol used between gnuplot and gnuplot_x11. I suspect that what has happened is that you upgraded gnuplot but did not replace an outdated installation of gnuplot_x11. Easy test: cd .../src setenv GNUPLOT_DRIVER_DIR . ./gnuplot set term x11; test Ethan > cvs -z3 > -d:pserver:ano...@gn...:/cvsroot/gnuplot co -D > 2012-10-04 -P gnuplot > > rather than lines on the right side there are all kinds of filled > polygons and strange lines randomly placed on the screen. > > As for the aspect ratio, I would guess that maybe this change: > > 2012-09-25 D.K. <> > > * src/gplt_x11.c src/mouse.c (do_event) term/x11.trm: > Feed back the x11 window size from gnuplot_x11 to gnuplot so that > the coordinates can be rescaled to maintain the correct aspect ratio. > This allows correct functioning of commands like 'set size square' and > 'set view equal xyz' in an interactive x11 output window. > > led to this. Perhaps something is overlooked in the test page. Maybe > it used to have some bad compensation from the past that is no longer > relevant after the fix of the aspect ratio code. > > As best I can figure for the random polygons, maybe this one: > > 2012-09-28 D.K. <> > > * src/gplt_x11.c src/gplt_x11.h: Remove dead code. > > * src/gplt_x11.c term/x11.trm: Modify format statements used to send > commands from x11.trm to gnuplot_x11. Before most integers were sent > using "%04d", now " %d". This prevents overflow for coordinate > 9999. > The extra byte required for a 4-digit coordinate is compensated by > fewer bytes needed for small integers like linetype. > > * src/gplt_x11.c src/gplt_x11.h: Adjust point size to accommodate > changes in window size. > > Dan |
|
From: Daniel J S. <dan...@ie...> - 2012-12-21 04:31:33
|
On 12/20/2012 10:08 PM, sfeam (Ethan Merritt) wrote: > On Thursday, 20 December 2012, Daniel J Sebald wrote: >> Hi Folks, >> >> Someone on the Octave list brought up an issue with requiring "set >> termoption dashed" to get dashed lines. The conclusion was that most >> terminals appear to work except X11. I thought Ethan had added dashed >> line support to X11 terminal some time ago. > > The problem is that x11 line types are controlled through the > XResource mechanism rather than from the command line. > You can do "set term x11 dash", but it only produces the > expected result if you have defined the dashed line types > in .XDefaults or another resource file. This is all documented > extensively. Sounds familiar. No luck so far, but where exactly these resource files are supposed to go is always tricky. >> Well, that got me to checking into the X11 terminal with the latest >> gnuplot CVS code. I found that the "test" screen is failing. As far >> back as September 26: >> >> cvs -z3 >> -d:pserver:ano...@gn...:/cvsroot/gnuplot co -D >> 2012-09-26 -P gnuplot >> >> things are beginning to not look correct. On that date the height of >> the test page is not correct within the X11 window. By October 04: > > That was around the time that Dima Kogan's updates to x11 started > to go in. They introduce changes in the protocol used between gnuplot > and gnuplot_x11. I suspect that what has happened is that you upgraded > gnuplot but did not replace an outdated installation of gnuplot_x11. > Easy test: > cd .../src > setenv GNUPLOT_DRIVER_DIR . > ./gnuplot > set term x11; test Ah yes. I should have just installed. Setting the variable works. Thanks, Dan |