|
From: Benjamin L. <lin...@gm...> - 2010-02-15 21:18:20
Attachments:
4.5.0_gp_save-as-emf.patch
4.4.0_gp_save-as-emf.patch
|
Hello, here's the next patch for the windows terminal: When developing the copy-to-clipboard code I realised that by virtually the same code one can save the EMF file to disk instead of copying it to the clipboard. The attached patch implements a "Save As EMF..." feature for the windows graph terminal, adds a menu entry and adds a Ctrl+S shortcut for the graph window. benjamin |
|
From: Benjamin L. <lin...@gm...> - 2010-02-15 21:18:27
|
Hello, And the next one in the windows term patch series: This one implements the "size" and "position" options to the windows terminal driver. benjamin |
|
From: Benjamin L. <lin...@gm...> - 2010-02-15 21:18:31
|
Hello, fourth patch in the series of windows term patches. This one fixes a bug in a call to _getcwd in wmenu.c The first parameter should be a char* but currently is of type char. trivial fix attached. benjamin |
|
From: Benjamin L. <lin...@gm...> - 2010-02-15 21:18:33
|
Hello, I've updated the patches for the windows terminal to today's CVS snapshots for both 4.5.0 and 4.4.0 and added the corresponding changelog entries. They work under win xp and microsoft office. I've split it into several smaller patches as to easier check/maintain them. Here's the first: 4.5.0_gp_emf-clipboard-copying.patch 4.4.0_gp_emf-clipboard-copying.patch changes the copy-to-clipboard code to create an enhanced metafile and cretaes a ctrl+c shortcut for it for the graph window only. benjamin |
|
From: Petr M. <mi...@ph...> - 2010-02-16 07:29:59
|
Hello, > > I've updated the patches for the windows terminal to today's CVS snapshots for > both 4.5.0 and 4.4.0 and added the corresponding changelog entries. They work > under win xp and microsoft office. thanks, I've committed all these patches. I've tested them on Linux/Wine. There I've experienced crash when after test Ctrl-C in graph window (or copy to clipboard) However, plot x Ctrl-C in graph window (or copy to clipboard) works fine (even when using title/ylabel with enhanced text strings). Does this happen also on your set-up? "Save as emf" also works correctly when I load that file into OpenOffice 3.2. Testing this by means of "test" command, I can see these two differences: - fill patterns are ignored - point type 7 looks like a very big circle (zoom it a bit). Under large zoom, it looks like two misplaced circles, one full and one empty. Can you please have a look? Petr |
|
From: Benjamin L. <lin...@gm...> - 2010-02-16 09:35:15
|
Petr Mikulik wrote: > Hello, >> I've updated the patches for the windows terminal to today's CVS snapshots for >> both 4.5.0 and 4.4.0 and added the corresponding changelog entries. They work >> under win xp and microsoft office. > > thanks, I've committed all these patches. > > I've tested them on Linux/Wine. There I've experienced crash when after > test > Ctrl-C in graph window (or copy to clipboard) > However, > plot x > Ctrl-C in graph window (or copy to clipboard) > works fine (even when using title/ylabel with enhanced text strings). > > Does this happen also on your set-up? No I don't see this. both Ctrl+C and selecting the menu item work correctly after a "test". > "Save as emf" also works correctly when I load that file into OpenOffice > 3.2. Testing this by means of "test" command, I can see these two > differences: > - fill patterns are ignored > - point type 7 looks like a very big circle (zoom it a bit). Under large > zoom, it looks like two misplaced circles, one full and one empty. Can you > please have a look? I don't have OpenOffice available right now, but I'll install it and check. benjamin |
|
From: Tatsuro M. <tma...@ya...> - 2010-02-17 03:50:01
|
Hello I have tested on windows xp --- Benjamin Lindner wrote: > Petr Mikulik wrote: > > Hello, > >> I've updated the patches for the windows terminal to today's CVS snapshots for > >> both 4.5.0 and 4.4.0 and added the corresponding changelog entries. They work > >> under win xp and microsoft office. > > > > thanks, I've committed all these patches. > > > > I've tested them on Linux/Wine. There I've experienced crash when after > > test > > Ctrl-C in graph window (or copy to clipboard) > > However, > > plot x > > Ctrl-C in graph window (or copy to clipboard) > > works fine (even when using title/ylabel with enhanced text strings). > > > > Does this happen also on your set-up? > > No I don't see this. both Ctrl+C and selecting the menu item work > correctly after a "test". In my case, the above also worked correct. BTW gbuplot> test Then copy to clipboard, paste to word 2003 The fill patterns are correct The point type 7 seems to be normal However, paste to OpenOffice 3.1.0 OOO310m11 (build 9399) The fill patterns are ignored and all are filled with black. > > "Save as emf" also works correctly when I load that file into OpenOffice > > 3.2. Testing this by means of "test" command, I can see these two > > differences: > > - fill patterns are ignored First test was the same as what Petr reported. However, after test, save emf file feature of 'test' screen worked fine. Interestingly, even if, I have exit gnuplot once then 'test' from the first prompt, the feature of save emf file of 'test' screen worked fine! Regards Tatsuro -------------------------------------- VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi] http://pr.mail.yahoo.co.jp/olympic/ |
|
From: Benjamin L. <lin...@gm...> - 2010-02-18 20:49:01
|
>> "Save as emf" also works correctly when I load that file into OpenOffice >> 3.2. Testing this by means of "test" command, I can see these two >> differences: >> - fill patterns are ignored >> - point type 7 looks like a very big circle (zoom it a bit). Under large >> zoom, it looks like two misplaced circles, one full and one empty. Can you >> please have a look? > > I don't have OpenOffice available right now, but I'll install it and check. I have tested using OO 3.1 and I see the same problems. Also point types 1, 2, and 3 look not symmetrical. Further, rotated text is not rotated here. I remember reading about misplaced coordinates in metafiles in Petzold, perhaps I can find out something. benjamin |
|
From: Ethan M. <merritt@u.washington.edu> - 2010-02-16 18:32:11
|
On Monday 15 February 2010 23:29:47 Petr Mikulik wrote: > Hello, > > > > I've updated the patches for the windows terminal to today's CVS snapshots for > > both 4.5.0 and 4.4.0 and added the corresponding changelog entries. They work > > under win xp and microsoft office. > > thanks, I've committed all these patches. Great! Does this mean we can close out some or all of these bugs? 2710337 screendump command under Windows 2189383 win32 UI copy to clipboard unusable 2848002 Ctrl+C crashes windows console build 1918293 "Copy to Clipboard" on MS-Win32 clip "tails" of p,g,q and y > I've tested them on Linux/Wine. There I've experienced crash when after > test > Ctrl-C in graph window (or copy to clipboard) > However, > plot x > Ctrl-C in graph window (or copy to clipboard) > works fine (even when using title/ylabel with enhanced text strings). > > Does this happen also on your set-up? It would not surprise me that interrupting "test" fails, even though interrupting a normal plot succeeds. The "test" command does not set up a full plot environment. But it sounds fixable. -- Ethan A Merritt Biomolecular Structure Center University of Washington, Seattle 98195-7742 |
|
From: Tatsuro M. <tma...@ya...> - 2010-02-17 02:23:26
|
Hello
--- Ethan Merritt wrote:
> Does this mean we can close out some or all of these bugs?
> 2848002 Ctrl+C crashes windows console build
No modification seems to be applied to plot.c
(void) signal(SIGINT, (sigfunc) inter);
Perhaps this issue still remains.
Regards
Tatsuro
--------------------------------------
VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
http://pr.mail.yahoo.co.jp/olympic/
|
|
From: Tatsuro M. <tma...@ya...> - 2010-02-17 03:53:12
|
Hello --- Tatsuro MATSUOKA wrote: > Hello > > > --- Ethan Merritt wrote: > > Does this mean we can close out some or all of these bugs? > > 2848002 Ctrl+C crashes windows console build > > No modification seems to be applied to plot.c > > (void) signal(SIGINT, (sigfunc) inter); > > Perhaps this issue still remains. I have confirmed that the above is still unsolved. Regards Tatsuro -------------------------------------- VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi] http://pr.mail.yahoo.co.jp/olympic/ |
|
From: Petr M. <mi...@ph...> - 2010-02-17 08:03:19
|
> > Does this mean we can close out some or all of these bugs? > > 2848002 Ctrl+C crashes windows console build > > No modification seems to be applied to plot.c > > (void) signal(SIGINT, (sigfunc) inter); > > Perhaps this issue still remains. Should I commit it to cvs? http://sourceforge.net/tracker/?func=detail&aid=2848002&group_id=2055&atid=102055 Are there any other patches that need a commit? --- PM |
|
From: Tatsuro M. <tma...@ya...> - 2010-02-17 11:32:25
|
Hello I have tried to see what happens with pressing CTRL+C. http://old.nabble.com/Re%3A-towards-4.4-(ctrl%2Bc-issue-for-gnuplot.exe(windows))-p27527817.html http://old.nabble.com/Re%3A-towards-4.4-(ctrl%2Bc-issue-for-gnuplot.exe(windows))-p27527993.html This problem is not easy to fix completely. At this moment, I vote to Benjamin's proposal. +#if defined(WGP_CONSOLE) + (void) signal(SIGINT, SIG_IGN); +#else (void) signal(SIGINT, (sigfunc) inter); +#endif Addition of something like /* Fix me */ is preferred for me. ********** +#if defined(WGP_CONSOLE) + /* Fix me. CTRC+C crashes console mode gnuplot for windows. failure of longjmp() is not easy to fix so that the signal of SIGINT is just ignored at the moment */ ******* Regards Tatsuro --- Petr Mikulik wrote: > > > Does this mean we can close out some or all of these bugs? > > > 2848002 Ctrl+C crashes windows console build > > > > No modification seems to be applied to plot.c > > > > (void) signal(SIGINT, (sigfunc) inter); > > > > Perhaps this issue still remains. > > Should I commit it to cvs? > http://sourceforge.net/tracker/?func=detail&aid=2848002&group_id=2055&atid=102055 > > Are there any other patches that need a commit? > > --- > PM > -------------------------------------- VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi] http://pr.mail.yahoo.co.jp/olympic/ |
|
From: Petr M. <mi...@ph...> - 2010-02-17 22:41:28
|
> Hello > > I have tried to see what happens with pressing CTRL+C. > > http://old.nabble.com/Re%3A-towards-4.4-(ctrl%2Bc-issue-for-gnuplot.exe(windows))-p27527817.html > http://old.nabble.com/Re%3A-towards-4.4-(ctrl%2Bc-issue-for-gnuplot.exe(windows))-p27527993.html > > This problem is not easy to fix completely. At this moment, I vote to Benjamin's proposal. > > +#if defined(WGP_CONSOLE) > + (void) signal(SIGINT, SIG_IGN); > +#else > (void) signal(SIGINT, (sigfunc) inter); > +#endif > > Addition of something like /* Fix me */ is preferred for me. > ********** > +#if defined(WGP_CONSOLE) > + /* Fix me. CTRC+C crashes console mode gnuplot for windows. > failure of longjmp() is not easy to fix so that the signal of SIGINT is just ignored > at the moment */ > ******* Thanks, I've committed the code to cvs. Petr |
|
From: Benjamin L. <lin...@gm...> - 2010-02-15 21:18:49
|
Hello, the next patch in the series: This one fixes the current behaviour of ignoring the explicit font name and size in "set label". benjamin |
|
From: Benjamin L. <lin...@gm...> - 2010-02-15 21:19:17
|
Hello, last patch in the series: This patch adds the option "close" to the windows terminal driver. I took the liberty of imitating the code of the wxt terminal and adapt for the windows terminal. I tested it for 4.5.0 and 4.4.0 on windows xp and it works OK. benjamin |