|
From: Tatsuro M. <tma...@ya...> - 2009-09-28 10:52:48
Attachments:
makefile.mgw.patch
|
Hello With the kind help by Benjamin I have succeeded to build console mode gnuplot 4.3 for windows with the wxt terminal. The problem caused by the flag: '-Wl,--subsystem,windows -mwindows' in the wx-config. http://www.nabble.com/console-mode-gnuplot-for-windows-with-wxt-doen-not-work-(gnuplot-4.3---mingw)-td25536073.html The patch attached enable us to build console mode of gnuplot 4.3 for windows without modifying wx-config. In my opinion, the flag '-Wl,--subsystem,windows -mwindows' in wx-config for wxMSW is to be removed. I have posted my opinion to the wx-develop post. However at the moment, I cannot say that my opinion will be accepted. Therefore I propose the patch attached. Regards Tatsuro -------------------------------------- Yahoo! JAPAN - Internet Security for teenagers and parents. http://pr.mail.yahoo.co.jp/security/ -------------------------------------- Yahoo! JAPAN - Internet Security for teenagers and parents. http://pr.mail.yahoo.co.jp/security/ -------------------------------------- Yahoo! JAPAN - Internet Security for teenagers and parents. http://pr.mail.yahoo.co.jp/security/ |
|
From: Tatsuro M. <tma...@ya...> - 2009-09-28 21:02:16
|
Hello --- Tatsuro MATSUOKA wrote: > In my opinion, the flag '-Wl,--subsystem,windows -mwindows' in wx-config for wxMSW is to be > removed. > I have posted my opinion to the wx-develop post. However at the moment, I cannot say that my > opinion > will be accepted. Therefore I propose the patch attached. My proposal was rejected by the wxWidgets developper. http://groups.google.co.jp/group/wx-dev/browse_thread/thread/65a3af28e9a21bca# However I can get useful information for disabling the the flag '-Wl,--subsystem,windows -mwindows': override it by a subsequent -Wl,--subsequent,console. I will reconsider the patch. Regards Tatsuro -------------------------------------- Yahoo! JAPAN - Internet Security for teenagers and parents. http://pr.mail.yahoo.co.jp/security/ |
|
From: Tatsuro M. <tma...@ya...> - 2009-09-29 01:18:08
Attachments:
makefile.mgw.1.patch
makefile.mgw.2.patch
|
Hello After discussion with Vadim Zeitlin, who is one of the developer of wxWidget, in the following address http://groups.google.co.jp/group/wx-dev/browse_thread/thread/65a3af28e9a21bca/89264cf1c66e16f3#89264cf1c66e16f3 I consider two different patch. First one, 'makefile.mgw.1.patch' is the same as that I have proposed in the previous post. Second one is add overrideng option to when PIPES flag is on: 'makefile.mgw.2.patch' First patch: - WX_LIBS = $(shell wx-config --libs) + WX_LIBS = $(shell wx-config --libs | sed -e 's/ -Wl,--subsystem,windows -mwindows//') This removes '-Wl,--subsystem,windows -mwindows' flag Second patch: WX_LIBS = $(shell wx-config --libs) + ifdef PIPES + WX_LIBS += -Wl,--subsystem,console + endif add overrideing option for gnuplot.exe and wgnuplot_pipes.exe I cannot figure out which is better. Please discuss this matter and produce better patch. Of course, more smart ideas are highly welcome. Regards Tatsuro --- Tatsuro MATSUOKA wrote: > My proposal was rejected by the wxWidgets developper. > > http://groups.google.co.jp/group/wx-dev/browse_thread/thread/65a3af28e9a21bca# > > However I can get useful information for disabling the the flag '-Wl,--subsystem,windows > -mwindows': > override it by a subsequent -Wl,--subsequent,console. > > > I will reconsider the patch. -------------------------------------- Yahoo! JAPAN - Internet Security for teenagers and parents. http://pr.mail.yahoo.co.jp/security/ |
|
From: Benjamin L. <lin...@gm...> - 2009-09-29 18:49:12
|
Tatsuro MATSUOKA wrote: > Hello > > After discussion with Vadim Zeitlin, who is one of the developer of wxWidget, in the following address > > http://groups.google.co.jp/group/wx-dev/browse_thread/thread/65a3af28e9a21bca/89264cf1c66e16f3#89264cf1c66e16f3 > > I consider two different patch. First one, 'makefile.mgw.1.patch' is the same as that I have proposed > in the previous post. > Second one is add overrideng option to when PIPES flag is on: 'makefile.mgw.2.patch' > > First patch: > - WX_LIBS = $(shell wx-config --libs) > + WX_LIBS = $(shell wx-config --libs | sed -e 's/ -Wl,--subsystem,windows -mwindows//') > This removes '-Wl,--subsystem,windows -mwindows' flag I'd propose a more robust version like sed -e "s+-Wl,--subsystem,windows++g" -e "s+-mwindows++g" Removing should not be dependent on spaces and the actual order of the erroneus commands. > Second patch: > WX_LIBS = $(shell wx-config --libs) > + ifdef PIPES > + WX_LIBS += -Wl,--subsystem,console > + endif > add overrideing option for gnuplot.exe and wgnuplot_pipes.exe > > I cannot figure out which is better. Please discuss this matter and produce better patch. > Of course, more smart ideas are highly welcome. The former. The latter looks wrong and is highly unportable as it depends on the order of the flags on the command line and their interpreation by binutils. benjamin |
|
From: Tatsuro M. <tma...@ya...> - 2009-09-30 00:54:24
Attachments:
makefile.mgw.3.patch
|
Hello Benjamin --- Benjamin Lindner wrote: The flag "-mwindows" has nothing to do with whether an application is using GDI libraries or not. It specifies the type of startup code and entry point of the application. So I cannot follow the wxwidgets developers argumentation. But it's their decision to make. I agree. But it seem to difficult to make their decision to change. > However I can get useful information for disabling the the flag '-Wl,--subsystem,windows -mwindows': > override it by a subsequent -Wl,--subsequent,console. I am sorry but this is IMO a very bad solution to take. This depends on the order of arguments on the command line, is not portable and depends no binutils' actual interpretation of such a double-specfication. And it is simply wrong. An application is either a GUI-subsystem application or a console-subsystem application. If it's not a GUI application, one shouldn't say so in the first place and not change one's mind halfway through. It's not a clean method, IMO OK. I under stand your statement. Surely it should be clean. > Tatsuro MATSUOKA wrote: > > Hello > > > > After discussion with Vadim Zeitlin, who is one of the developer of wxWidget, in the following > address > > > > > http://groups.google.co.jp/group/wx-dev/browse_thread/thread/65a3af28e9a21bca/89264cf1c66e16f3#89264cf1c66e16f3 > > > > I consider two different patch. First one, 'makefile.mgw.1.patch' is the same as that I have > proposed > > in the previous post. > > Second one is add overrideng option to when PIPES flag is on: 'makefile.mgw.2.patch' > > > > First patch: > > - WX_LIBS = $(shell wx-config --libs) > > + WX_LIBS = $(shell wx-config --libs | sed -e 's/ -Wl,--subsystem,windows -mwindows//') > > This removes '-Wl,--subsystem,windows -mwindows' flag > > I'd propose a more robust version like > sed -e "s+-Wl,--subsystem,windows++g" -e "s+-mwindows++g" > Removing should not be dependent on spaces and the actual order of the > erroneus commands. > > > Second patch: > > WX_LIBS = $(shell wx-config --libs) > > + ifdef PIPES > > + WX_LIBS += -Wl,--subsystem,console > > + endif > > add overrideing option for gnuplot.exe and wgnuplot_pipes.exe > > > > I cannot figure out which is better. Please discuss this matter and produce better patch. > > Of course, more smart ideas are highly welcome. > > The former. The latter looks wrong and is highly unportable as it > depends on the order of the flags on the command line and their > interpreation by binutils. I submit a patch considering Benjamin suggestion. Benjamin. Thank you for your comprehensive and extensive suggestions. Regards Tatsuro -------------------------------------- Yahoo! JAPAN - Internet Security for teenagers and parents. http://pr.mail.yahoo.co.jp/security/ |
|
From: Benjamin L. <lin...@gm...> - 2009-09-29 18:49:06
|
Tatsuro MATSUOKA wrote: > Hello > > --- Tatsuro MATSUOKA wrote: >> In my opinion, the flag '-Wl,--subsystem,windows -mwindows' in wx-config for wxMSW is to be >> removed. >> I have posted my opinion to the wx-develop post. However at the moment, I cannot say that my >> opinion >> will be accepted. Therefore I propose the patch attached. > > My proposal was rejected by the wxWidgets developper. > > http://groups.google.co.jp/group/wx-dev/browse_thread/thread/65a3af28e9a21bca# > The flag "-mwindows" has nothing to do with whether an application is using GDI libraries or not. It specifies the type of startup code and entry point of the application. So I cannot follow the wxwidgets developers argumentation. But it's their decision to make. > However I can get useful information for disabling the the flag '-Wl,--subsystem,windows -mwindows': > override it by a subsequent -Wl,--subsequent,console. I am sorry but this is IMO a very bad solution to take. This depends on the order of arguments on the command line, is not portable and depends no binutils' actual interpretation of such a double-specfication. And it is simply wrong. An application is either a GUI-subsystem application or a console-subsystem application. If it's not a GUI application, one shouldn't say so in the first place and not change one's mind halfway through. It's not a clean method, IMO benjamin |