gnuplot-beta

wmenu.c

[Allin C. <cot...@wf...>]

When cross-building wgnuplot.exe on Linux using mingw,
I get this warning:

win/wmenu.c: In function `SendMacro':
win/wmenu.c:402: warning: passing arg 1 of `_getcwd' from 
incompatible pointer type

The call in wmenu.c is

    char cwd[MAX_PATH];
    <snip>
    _getcwd(&cwd, sizeof(cwd));

And msdn
http://msdn2.microsoft.com/en-us/library/sf98bd4y(VS.80).aspx
gives as prototype for _getcwd:

char *_getcwd( 
   char *buffer,
   int maxlen 
);

So it looks as if the call is indeed wrong -- the first arg should 
be cwd, not &cwd? -- but I might be missing something.

-- 
Allin Cottrell
Department of Economics
Wake Forest University, NC

Re: wmenu.c

[<HBB...@t-...>]

Allin Cottrell wrote:
> win/wmenu.c: In function `SendMacro':
> win/wmenu.c:402: warning: passing arg 1 of `_getcwd' from 
> incompatible pointer type
> 
> The call in wmenu.c is
> 
>     char cwd[MAX_PATH];
>     <snip>
>     _getcwd(&cwd, sizeof(cwd));

> So it looks as if the call is indeed wrong -- the first arg should 
> be cwd, not &cwd? -- but I might be missing something.

The call is neither quite wrong, nor quite right.  &cwd and cwd 
eventually express the same address, so no harm done.  The pointer type 
will be converted automatically.  _getcwd(cwd, sizeof(cwd)) would be 
better, but not so much that it'd actually make a difference :-)