On Friday 28 July 2006 12:59 am, Timoth=C3=A9e Lecomte wrote:
>=20
> Ethan in particular, as you were not there to give your point of view,
>=20
> Dmitri A. Sergatskov reported a problem to compile from CVS a few days=20
> ago on the list. 'make' on a fresh installation fails in tutorial=20
> because gnuplot_x11 is not found.=20
I replied separately just a moment ago, but to recap:
I can reproduce the error messages easily enough, and I understand why
your patch makes them go away. =20
But I cannot reproduce the build failure. =20
=46or me it emits these messages but completes normally, as you would expect
since the x11 driver is not actually used by the scripts in this directory.
=20
> But this leaves the question open : should the change for bug #1509033=20
> be reverted (at the price of GNUTERM possibly causing some drivers to=20
> segfault unless we check all of them), or can we live with gnuplot_x11=20
> always starting and just apply the quick fix ?
plot.c used to check explicitly for png/jpeg/tgif, and only call term->init=
()
for these cases. This was wrong, if only because 'gif' should have been
on that list also.
The fix for #1509033 was to call term->init() in all cases. However, this
triggers overhead for x11 that turns out to be unnecessary if the user
switches to another terminal for plotting.
I suggest a middle course. Let's have a list of "don't call me" drivers
rather than a list of "call me" drivers. Right now the only candidate
for the "don't call me" list is x11.
As to the patch you sent Dmitri, isn't it more logical to fix things
by having the Makefile set GNUTERM to "pslatex" prior to calling
gnuplot?
=2D-=20
Ethan A Merritt
Biomolecular Structure Center
University of Washington, Seattle 98195-7742
|
