gnuplot-beta

widthflag in enhanced text mode

[<tim...@en...>]

Hi !

After a review of the code of the enhanced text mode, I think the
'widthflag' argument is never used (I mean it's always true). It's a
flag which is told to mean that the size of the character to draw must
not be taken into account if it's set to false. The code in term.c
(enhanced_recursion) just propagates its value without modifying it, and
terminals initialize it to true. For example, see post.trm
(ENHPS_put_text). It may be interesting to remove this flag... It may
help me (and other terminal developpers) to avoid to implement useless
code ;-) ... and maybe to avoid possible errors ...

Any idea about this ? (Ethan A Merritt especially, as it was you who
abstracted this text mode)

Best regards,

Timoth=E9e Lecomte

Re: widthflag in enhanced text mode

[Hans-Bernhard B. <br...@ph...>]

Timoth=E9e Lecomte wrote:
> After a review of the code of the enhanced text mode, I think the
> 'widthflag' argument is never used (I mean it's always true).=20

Your review missed the important part of the code.

Yes, "widthflag" is always passed into the recursion as TRUE, by the=20
terminal drivers.  But it will sometimes be changed to FALSE in=20
recursive calls from enhanced_recursion to itself.  Basically, widthflag =

is the implementation of the '~' overprinting feature --- find it in the =

source and you'll see this argument being passed as 'FALSE'.

Re: widthflag in enhanced text mode

[<tim...@en...>]

Hans-Bernhard Broeker wrote:

> Timoth=E9e Lecomte wrote:
>
>> After a review of the code of the enhanced text mode, I think the
>> 'widthflag' argument is never used (I mean it's always true).=20
>
>
> Your review missed the important part of the code.
>
> Yes, "widthflag" is always passed into the recursion as TRUE, by the
> terminal drivers.  But it will sometimes be changed to FALSE in
> recursive calls from enhanced_recursion to itself.  Basically,
> widthflag is the implementation of the '~' overprinting feature ---
> find it in the source and you'll see this argument being passed as
> 'FALSE'.
>
Wow ! I missed my magnifier ;-)
Indeed, I had forgotten the way overprinting works. So, let's forget my
suggestion, as implement this widthflag...

Thanks you very much for your quick answer. I will try to pay more
attention the next time I think something is useless !

Timoth=E9e Lecomte

Re: widthflag in enhanced text mode

[Ethan M. <merritt@u.washington.edu>]

On Tuesday 01 November 2005 07:59 am, Timoth=E9e Lecomte wrote:
>=20
> After a review of the code of the enhanced text mode, I think the
> 'widthflag' argument is never used (I mean it's always true). It's a
> flag which is told to mean that the size of the character to draw must
> not be taken into account if it's set to false.

As you state, this flag indicates whether or not the current text
position should be set at the beginning (FALSE) or end (TRUE) of
the string being passed.  This flag is set to FALSE in order to
overprint text (enhanced text mode symbol '~').

See line 2507 of term.c


	Ethan














> The code in term.c=20
> (enhanced_recursion) just propagates its value without modifying it, and
> terminals initialize it to true. For example, see post.trm
> (ENHPS_put_text). It may be interesting to remove this flag... It may
> help me (and other terminal developpers) to avoid to implement useless
> code ;-) ... and maybe to avoid possible errors ...
>=20
> Any idea about this ? (Ethan A Merritt especially, as it was you who
> abstracted this text mode)
>=20
> Best regards,
>=20
> Timoth=E9e Lecomte
>=20
>=20
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server. Downl=
oad
> it for free - -and be entered to win a 42" plasma tv or your very own
> Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
>=20

=2D-=20
Ethan A Merritt       merritt@u.washington.edu
Biomolecular Structure Center
Mailstop 357742
University of Washington, Seattle, WA 98195