gnuplot-beta

compile faild at term/fig.trm

[Shigeharu T. <sh...@ie...>]

shige 12/03 2004
----------------

I compiled current CVS version of gnuplot on 

 OS: Solaris 2.6 
 Compiler: gcc-2.95.3

But the compile of term/fig.trm (rev. 1.47) is failed. The 
following patch fixes it.

----- From here -----
--- term/fig.trm.ORG	Fri Dec  3 19:53:18 2004
+++ term/fig.trm	Fri Dec  3 20:47:57 2004
@@ -1107,11 +1107,12 @@
 TERM_PUBLIC void FIG_set_color(t_colorspec *colorspec)
 {
     double gray = colorspec->value;
+    int new_color;
 
     if (colorspec->type != TC_FRAC)
 	return;
 
-    int new_color = (gray <= 0) ? 0 : (int)(gray * sm_palette.colors);
+    new_color = (gray <= 0) ? 0 : (int)(gray * sm_palette.colors);
     if (new_color >= FIG_palette_size)
 	new_color = FIG_palette_size - 1;
     if (FIG_palette_set == FALSE) {
----- To here -----

+========================================================+
 Shigeharu TAKENO     NIigata Institute of Technology
                       kashiwazaki,Niigata 945-1195 JAPAN
 sh...@ie...   TEL(&FAX): +81-257-22-8161
+========================================================+

Re: compile faild at term/fig.trm

[Hans-Bernhard B. <br...@ph...>]

Shigeharu TAKENO wrote:

>      double gray = colorspec->value;
> +    int new_color;
>  
>      if (colorspec->type != TC_FRAC)
>  	return;
>  
> -    int new_color = (gray <= 0) ? 0 : (int)(gray * sm_palette.colors);
> +    new_color = (gray <= 0) ? 0 : (int)(gray * sm_palette.colors);

Thanks for spotting this.  I'm checking in that fix right away.

Reminder to all: we're not even fully up to ANSI/ISO C89 yet.  Which 
means: no C99 nor C++ specialities are allowed in gnuplot's source (yes, 
Petr, that does mean no // style comments, either...).  People using GCC 
version 3 or higher may have to configure with the appropriate CFLAGS 
set to disallow C99-isms like the above from creeping into the CVS.

Re: compile faild at term/fig.trm

[Daniel J S. <dan...@ie...>]

Hans-Bernhard Broeker wrote:

> Reminder to all: we're not even fully up to ANSI/ISO C89 yet.  Which 
> means: no C99 nor C++ specialities are allowed in gnuplot's source 
> (yes, Petr, that does mean no // style comments, either...).


Hey!  Petr is the one who always catches the // I put in code.  (Since 
there are supposed to be no // in the code, I use the double backslash 
to temporarily comment out lines of code... then forget to clean.)

:-)