gnuplot-beta

commit [edccc6] perhaps breaks caca term build

[Tatsuro M. <tma...@ya...>]

In file included from ../../gnuplot-gnuplot-main/src/term.h:227:0,
                 from ../../gnuplot-gnuplot-main/src/term.c:1189:
../../gnuplot-gnuplot-main/term/caca.trm: In function 'CACA_init_display':
../../gnuplot-gnuplot-main/term/caca.trm:771:23: error: 'current_locale' undeclared (first use in this function); did you mean 'surface_lscale'?
    setlocale(LC_TIME, current_locale != NULL ? current_locale : "C");
                       ^~~~~~~~~~~~~~
                       surface_lscale
../../gnuplot-gnuplot-main/term/caca.trm:771:23: note: each undeclared identifier is reported only once for each function it appears in
make[4]: *** [Makefile:910: term.o] Error 1


Tatsuro

Re: commit [edccc6] perhaps breaks caca term build

[Ethan A M. <sf...@us...>]

On Thursday, September 6, 2018 4:11:53 PM PDT Tatsuro MATSUOKA wrote:
> In file included from ../../gnuplot-gnuplot-main/src/term.h:227:0,
>                  from ../../gnuplot-gnuplot-main/src/term.c:1189:
> ../../gnuplot-gnuplot-main/term/caca.trm: In function 'CACA_init_display':
> ../../gnuplot-gnuplot-main/term/caca.trm:771:23: error: 'current_locale' undeclared (first use in this function); did you mean 'surface_lscale'?
>     setlocale(LC_TIME, current_locale != NULL ? current_locale : "C");
>                        ^~~~~~~~~~~~~~
>                        surface_lscale
> ../../gnuplot-gnuplot-main/term/caca.trm:771:23: note: each undeclared identifier is reported only once for each function it appears in
> make[4]: *** [Makefile:910: term.o] Error 1
> 
> 
> Tatsuro

My bad.  I missed that one.
I am starting to think that all this locale fixup should be done by the "set term"
command rather than by individual terminal drivers.

	Ethan

Re: commit [edccc6] perhaps breaks caca term build

[Tatsuro M. <tma...@ya...>]

----- Original Message -----

>>  In file included from ../../gnuplot-gnuplot-main/src/term.h:227:0,
>>                   from ../../gnuplot-gnuplot-main/src/term.c:1189:
>>  ../../gnuplot-gnuplot-main/term/caca.trm: In function 
> 'CACA_init_display':
>>  ../../gnuplot-gnuplot-main/term/caca.trm:771:23: error: 
> 'current_locale' undeclared (first use in this function); did you mean 
> 'surface_lscale'?
>>      setlocale(LC_TIME, current_locale != NULL ? current_locale : 
> "C");
>>                         ^~~~~~~~~~~~~~
>>                         surface_lscale
>>  ../../gnuplot-gnuplot-main/term/caca.trm:771:23: note: each undeclared 
> identifier is reported only once for each function it appears in
>>  make[4]: *** [Makefile:910: term.o] Error 1
>> 
>> 
>>  Tatsuro
> 
> My bad.  I missed that one.
> I am starting to think that all this locale fixup should be done by the 
> "set term"
> command rather than by individual terminal drivers.
> 
>     Ethan
> 


Thanks for quick fix.

> I am starting to think that all this locale fixup should be done by the 
> "set term"
> command rather than by individual terminal drivers.

It's a nice change. 

Tatsuro