gnuplot-beta

Problems building 6.0.rc2

[Philipp K. J. <ja...@ie...>]

I am encountering a compilation error when
trying to build from the current rc2 tarball.

After ./configure and make, several files
compile, until I hit this (more details in
attached text file):



In file included from term.h:289,
                 from term.c:1219:
../term/post.trm:4036:11: error: expected declaration specifiers or
‘...’ before string constant 4036 |     fputs("%%%%BeginImage\n",
gppsfile); |           ^~~~~~~~~~~~~~~~~~
../term/post.trm:4036:31: error: expected declaration specifiers or
‘...’ before ‘gppsfile’ 4036 |     fputs("%%%%BeginImage\n", gppsfile);
      |                               ^~~~~~~~



I currently don't have devel packages for
pango, cairo, etc installed, but I thought
gnuplot should still build with the "dumb"
terminal at least. Or am I missing some
build-tool? (This is on Linux Mint 21.)

I can provide more detail. What would be
most helpful?

Best,

		Ph.

-- 

Philipp K. Janert
www.janert.me

Re: Problems building 6.0.rc2

[Ethan A M. <me...@uw...>]

On Friday, 13 October 2023 15:06:27 PDT Philipp K. Janert via gnuplot-beta wrote:
> 
> I am encountering a compilation error when
> trying to build from the current rc2 tarball.
> 
> After ./configure and make, several files
> compile, until I hit this (more details in
> attached text file):

Thanks for the report.

Yeah, there is a mis-matched curly bracket in the conditional compilation
logic for building the PostScript terminal if neither gd or cairo is also built.

This is bug #2659
   https://sourceforge.net/p/gnuplot/bugs/2659/

Fixed in this commit for -rc3

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
commit 67db7c4e11b769018d74c432136fb1c84ab985d0
Author: Peter Korsgaard <pe...@ko...>
Date:   Sun Oct 1 10:20:31 2023 +0200

    term/post.trm: unbreak !HAVE_DEFLATE_ENCODER builds
    
    Commit 2f2cf617808 (post: handle RGBA images (only current use is to render
    a pixmap)) added an extra '}' outside the HAVE_DEFLATE_ENCODER (gd support)
    conditional, leading to build breakage:
    
    In file included from term.h:298,
                     from term.c:1211:
    ../term/post.trm:4016:11: error: expected declaration specifiers or '...' before string constant
     4016 |     fputs("%%%%BeginImage\n", gppsfile);
    
    http://autobuild.buildroot.net/results/5676609b6331b645f2e557aca67afe4c3a087433/build-end.log
    
    Fix it by dropping the extra { } added by the above commit.
    
    Signed-off-by: Peter Korsgaard <pe...@ko...>
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Minimal patch attached


    Ethan




> 
> 
> In file included from term.h:289,
>                  from term.c:1219:
> ../term/post.trm:4036:11: error: expected declaration specifiers or
> ‘...’ before string constant 4036 |     fputs("%%%%BeginImage\n",
> gppsfile); |           ^~~~~~~~~~~~~~~~~~
> ../term/post.trm:4036:31: error: expected declaration specifiers or
> ‘...’ before ‘gppsfile’ 4036 |     fputs("%%%%BeginImage\n", gppsfile);
>       |                               ^~~~~~~~
> 
> 
> 
> I currently don't have devel packages for
> pango, cairo, etc installed, but I thought
> gnuplot should still build with the "dumb"
> terminal at least. Or am I missing some
> build-tool? (This is on Linux Mint 21.)
> 
> I can provide more detail. What would be
> most helpful?
> 
> Best,
> 
> 		Ph.
> 
> 

Re: Problems building 6.0.rc2

[Philipp K. J. <ja...@ie...>]

On Fri, 13 Oct 2023 17:22:38 -0700
Ethan A Merritt <me...@uw...> wrote:

> On Friday, 13 October 2023 15:06:27 PDT Philipp K. Janert via
> gnuplot-beta wrote:
> > 
> > I am encountering a compilation error when
> > trying to build from the current rc2 tarball.
> > 
> > After ./configure and make, several files
> > compile, until I hit this (more details in
> > attached text file):  
> 
> Thanks for the report.
> 
> Yeah, there is a mis-matched curly bracket in the conditional
> compilation logic for building the PostScript terminal if neither gd
> or cairo is also built.

Thanks! (But see my other mail.)

> 
> This is bug #2659
>    https://sourceforge.net/p/gnuplot/bugs/2659/
> 
> Fixed in this commit for -rc3
> 
> %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
> commit 67db7c4e11b769018d74c432136fb1c84ab985d0
> Author: Peter Korsgaard <pe...@ko...>
> Date:   Sun Oct 1 10:20:31 2023 +0200
> 
>     term/post.trm: unbreak !HAVE_DEFLATE_ENCODER builds
>     
>     Commit 2f2cf617808 (post: handle RGBA images (only current use is
> to render a pixmap)) added an extra '}' outside the
> HAVE_DEFLATE_ENCODER (gd support) conditional, leading to build
> breakage: 
>     In file included from term.h:298,
>                      from term.c:1211:
>     ../term/post.trm:4016:11: error: expected declaration specifiers
> or '...' before string constant 4016 |     fputs("%%%%BeginImage\n",
> gppsfile); 
>     http://autobuild.buildroot.net/results/5676609b6331b645f2e557aca67afe4c3a087433/build-end.log
>     
>     Fix it by dropping the extra { } added by the above commit.
>     
>     Signed-off-by: Peter Korsgaard <pe...@ko...>
> %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
> 
> Minimal patch attached
> 
> 
>     Ethan
> 
> 
> 
> 
> > 
> > 
> > In file included from term.h:289,
> >                  from term.c:1219:
> > ../term/post.trm:4036:11: error: expected declaration specifiers or
> > ‘...’ before string constant 4036 |     fputs("%%%%BeginImage\n",
> > gppsfile); |           ^~~~~~~~~~~~~~~~~~
> > ../term/post.trm:4036:31: error: expected declaration specifiers or
> > ‘...’ before ‘gppsfile’ 4036 |     fputs("%%%%BeginImage\n",
> > gppsfile); |                               ^~~~~~~~
> > 
> > 
> > 
> > I currently don't have devel packages for
> > pango, cairo, etc installed, but I thought
> > gnuplot should still build with the "dumb"
> > terminal at least. Or am I missing some
> > build-tool? (This is on Linux Mint 21.)
> > 
> > I can provide more detail. What would be
> > most helpful?
> > 
> > Best,
> > 
> > 		Ph.
> > 
> >