gnuplot-beta

Crash with postscript terminal

[MortenMacFly <ma...@gm...>]

The current CVS version of Gnuplot crashes for the following script on
Windows:
set terminal postscript
set output "pstest.eps"
plot sin(x)
I have compiled GP myself successfully for the last couple of years, no
problems at all with this driver. Today I had to create the prologues.h file
myself using the ps_header.sh script as the current one in CVS is too old
and thus compilation broken. But: A comparision between the old, and new
prologues.h showed the creation is in fact OK.
Here are some more details:
- created prologues.h using cygwin
- created GP using MSVC6 (makefile.nt)
- modified makefile.nt NOT to define GNUPLOT_PS_DIR so that the PS sources
are included (and in fact they are)
All this worked 100% in the past (last compilation was around October of
last year though) but now it's broken.
With regards, Morten.
-- 
View this message in context: http://www.nabble.com/Crash-with-postscript-terminal-tp15040716p15040716.html
Sent from the Gnuplot - Dev mailing list archive at Nabble.com.

Re: Crash with postscript terminal

[MortenMacFly <ma...@gm...>]

MortenMacFly wrote:
> 
> The current CVS version of Gnuplot crashes for the following script on
> Windows:
> set terminal postscript
> set output "pstest.eps"
> plot sin(x)
> 

I digged into this myself and found a serious bug in the postscript terminal
driver. The fact that it was working before for me was that the envvar
"GNUPLOT_PS_DIR" was defined at compile time. Now that it is not (as I
changed the makefile) and I am using the internal prologue (that gets
compiled into the executable) the bug was raised on my machine.

Anyways - I was able to fix it. See patch #1878095
(http://sourceforge.net/tracker/index.php?func=detail&aid=1878095&group_id=2055&atid=302055)
for a proper fix. I hope this gets applied at some time cause this is really
a bad bug.

With regards, Morten.
-- 
View this message in context: http://www.nabble.com/Crash-with-postscript-terminal-tp15040716p15041572.html
Sent from the Gnuplot - Dev mailing list archive at Nabble.com.

Re: Crash with postscript terminal

[Ethan M. <merritt@u.washington.edu>]

On Wednesday 23 January 2008 07:28, MortenMacFly wrote:

> I digged into this myself and found a serious bug in the postscript terminal
> driver. The fact that it was working before for me was that the envvar
> "GNUPLOT_PS_DIR" was defined at compile time. Now that it is not (as I
> changed the makefile) and I am using the internal prologue (that gets
> compiled into the executable) the bug was raised on my machine.
> 
> Anyways - I was able to fix it. See patch #1878095
> (http://sourceforge.net/tracker/index.php?func=detail&aid=1878095&group_id=2055&atid=302055)
> for a proper fix. I hope this gets applied at some time cause this is really
> a bad bug.

I will apply your patch to the current CVS version.

Could you please check whether an equivalent patch is needed for version 4.2,
and if so prepare a patch for the 4.2 source tree also?

	thanks,

		Ethan

Re: Crash with postscript terminal

[MortenMacFly <ma...@gm...>]

Ethan Merritt wrote:
> 
> Could you please check whether an equivalent patch is needed for version
> 4.2
> 
I checked out the branch "Release_4_2_1" (if that is hopefully what you
mean). It's not required there as the function "PS_dump_prologue_file" does
not return a file pointer but handles all itself. So this shouldn't be
broken.
With regards, Morten.
PS: BTW: This also explains why it was working all the time last year - it
seems this separation of the functions in HEAD is "brand new"...
-- 
View this message in context: http://www.nabble.com/Crash-with-postscript-terminal-tp15040716p15060756.html
Sent from the Gnuplot - Dev mailing list archive at Nabble.com.

Re: Crash with postscript terminal

[MortenMacFly <ma...@gm...>]

MortenMacFly wrote:
> 
> I checked out the branch "Release_4_2_1"
> 
I realised there is also a branch called "Release_4_4_2". (Maybe a typo but
should read "Release_4_2_2"???) This one is not affected, too. No issues.
With regards, Morten.
-- 
View this message in context: http://www.nabble.com/Crash-with-postscript-terminal-tp15040716p15060826.html
Sent from the Gnuplot - Dev mailing list archive at Nabble.com.

Re: Crash with postscript terminal

[Ethan M. <merritt@u.washington.edu>]

On Thursday 24 January 2008 00:43, MortenMacFly wrote:
> 
> Ethan Merritt wrote:
> > 
> > Could you please check whether an equivalent patch is needed for version
> > 4.2
> > 
> I checked out the branch "Release_4_2_1" (if that is hopefully what you
> mean). It's not required there as the function "PS_dump_prologue_file" does
> not return a file pointer but handles all itself. So this shouldn't be
> broken.

OK. Thanks.

Because this still doesn't handle the case of UTF-8 + adobeglyphnames,
I also made the error message a non-fatal warning.  This should clue in
the user that they need to set GNUPLOT_PS_DIR in the environment, and
point it to some usable directory containing the glyph tables if they
need anything beyond the default set of glyphs.

-- 
Ethan A Merritt