gnuplot-beta — Developers and beta testers of new gnuplot code

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Teo S B. <teo...@gm...>]

I gave an argument for allowing trailing definitions at bottom of
http://article.gmane.org/gmane.comp.graphics.gnuplot.devel/9253

On Sun, Feb 14, 2010 at 9:24 PM, Ethan Merritt <merritt@u.washington.edu> wrote:
> On Sunday 14 February 2010, Teo S Bernhard wrote:
>> historic gnuplot implementations. See the brief usage instruction:
>>      plot {<ranges>}
>>              {<iteration>}
>>              {<function> | {"<datafile>" {datafile-modifiers}}}
>>              {axes <axes>} {<title-spec>} {with <style>}
>>              {, {definitions{,}} <function> ...}
>
> You are not interpreting this BNF description correctly.
> The meaning of the final line quoted immediately above is
>  "If you append a comma you must follow it with a function.
>   The function may optionally be preceded by a definition,
>   with or without a separating comma."
>
> The <function> element is not in curly brackets, and hence is
> not optional.  There is no expansion of this set of BNF rules that
> results in a trailing definition.  So no, the documentation
> has never stated that a trailing definition was valid syntax.

Agreed, but strict interpretation of this BNF does also tell that
initial definitions are disallowed. This contradicts a given example
of 'help plot' (version 4.2).

                     plot f(x) = sin(x*a), a = .2, f(x), a = .4, f(x)

Given also that the help text of gnuplot 4.2 says, from 'help plot':
   "It is also possible to define functions and parameters on the `plot` command
   itself.  This is done merely by isolating them from other items with commas."

The implementation of gnuplot 4.2 and 4.3 allows in a quite liberal
form definitions at both leading and trailing end of the plot command
as long a they are separated by comma, example:
              plot f(x) = sin(x*a), a = .2, f(x), a = .4, f(x), a=0.6

IMHO, the stated BNF contradicts other parts of the help text and also
the actual code-implementation.

For the historic (pre 4.4 rc1) gnuplot versions, a BNF consistent with
other help text and code-implementation (considering definitions
mainly) should be roughly:

     plot {<ranges>}
             {<iteration>}
             {definitions,}...
             { <function> | {"<datafile>" {datafile-modifiers}}}
             {axes <axes>} {<title-spec>} {with <style>}
             {,definitions}...  {,<function>... }

It is obviously a philosophical point, if implementation or
documentation should govern.
I think the historical implementation in this case.

Teo

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Hans-Bernhard B. <HBB...@t-...>]

Teo S Bernhard wrote:

> Your suggestion breaks  gridding/zooming/... capability in the plot.
> This happens because the a-variable is not initiated within the plot statement.
> I find when trying:    a=0; plot [0:1] a*x, a=a+1, a*x
> - while toggling the grid  I see that the first plot shows '1x' and
> 2x, while the second version shows: '3x' and '4x'.

So initialize it inside.  That still doesn't constitute a need to do 
something after the last of the data sets.

> The sole issue of mine is that gnuplot version 4.4 rc1 breaks backward
> compatibility 

No, it doesn't.  It's not an issue of compatibility if something that 
was never promised to work, stops to.

> below - that it is gnuplot 4.4.0 rc1 that is at odds with the
> documentation.

I disagree with that claim.  It was the earlier versions that were at 
odds with the documentation, by allowing things that the documentation 
said they didn't.

>   c) In the briefer usage instruction (repeated below) I notice the
> optional trailing comma after definitions {,},  I also notice the
> replaceable <function>.

And that means that a function (or datafile), _has_ to be there.  If 
it's not, that's disallowed by the syntax of the command.

>   Considering the interpretation of item c), practical experience with
> gnuplot versions 4.3, 4.2, 4.0,...,  suggest that there is no need for
> a trailing comma after a  definition if there is no trailing
> <function>, here <function> can be replaced by nothing. In my opinion,
> the latter is a reasonable interpretation which is supported by
> historic gnuplot implementations. See the brief usage instruction:
>      plot {<ranges>}
>              {<iteration>}
>              {<function> | {"<datafile>" {datafile-modifiers}}}
>              {axes <axes>} {<title-spec>} {with <style>}
>              {, {definitions{,}} <function> ...}

Well, since you want to base claims on history, let's step back just one 
release from 4.4-rc1, to 4.2pl5:

Syntax:
       plot {<ranges>}
            {<function> | {"<datafile>" {datafile-modifiers}}}
            {axes <axes>} {<title-spec>} {with <style>}
            {, {definitions,} <function> ...}

Note how that rather explicitly used to _require_ a comma after every 
definition, thereby forbidding what you were doing.  The only bug to be 
fixed here is in the old versions not flagging this usage error.

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Ethan M. <merritt@u.washington.edu>]

On Sunday 14 February 2010, Teo S Bernhard wrote:

>   c) In the briefer usage instruction (repeated below) I notice the
> optional trailing comma after definitions {,},  I also notice the
> replaceable <function>.
>   Considering the interpretation of item c), practical experience with
> gnuplot versions 4.3, 4.2, 4.0,...,  suggest that there is no need for
> a trailing comma after a  definition if there is no trailing
> <function>, here <function> can be replaced by nothing. In my opinion,
> the latter is a reasonable interpretation which is supported by
> historic gnuplot implementations. See the brief usage instruction:
>      plot {<ranges>}
>              {<iteration>}
>              {<function> | {"<datafile>" {datafile-modifiers}}}
>              {axes <axes>} {<title-spec>} {with <style>}
>              {, {definitions{,}} <function> ...}

You are not interpreting this BNF description correctly.
The meaning of the final line quoted immediately above is
  "If you append a comma you must follow it with a function.
   The function may optionally be preceded by a definition,
   with or without a separating comma."

The <function> element is not in curly brackets, and hence is
not optional.  There is no expansion of this set of BNF rules that 
results in a trailing definition.  So no, the documentation
has never stated that a trailing definition was valid syntax.
 
> My claim is therefore that previous gnuplot version, prior to gnuplot
> 4.4 rc1, behaved according to this documentation whereas version 4.4
> rc 1 does not behave according to the documentation regarding item c,
> this causes gnuplot 4.4 rc1 to break backwards compatibility.
> 
> If you agree, please consider the following patch vs. gnuplot 4.4 rc1
> for allowing trailing definitions in a plot command:  plot [-1:1] k=0,
> k*x, k=k+1, k*x, k=k+1
> As can be seen, only one code line needs to be modified - in two
> places. The modified if-statement is the one that causes an error
> message.
> With this modification, a trailing definition is silently accepted
> whereas earlier syntax errors are triggered as before.

I don't think it makes sense to do this without also doing one of 
the following:
 1) fix bug #2907028
 2) document that it is not permissible to use a definition of
    the form q = <expression involving q> inside a plot statment.
Otherwise it is nearly impossible to figure out how the program will
assign the instantaneous value of q is during the plot.
 

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[sfeam (E. Merritt) <eam...@gm...>]

On Sunday 14 February 2010, Hans-Bernhard Bröker wrote:
> > On Friday 12 February 2010 11:26:36 Teo S Bernhard wrote:
> 
> >>>> the below shortened example reproducing the error message:
> >>>>
> >>>>
> >>>> # file: trial.gpl
> >>>> f(x)=x
> >>>> plot a=1, \
> >>>>      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
> >>>>      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
> >>>>      a=0 
> 
> I see no particularly compelling reason why this can't be changed to
> 
> a=0 ; plot \
>       f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1, \
>       f(x)*a   title "data from index a=2" w l lw 2 lt a ; a = 0
> 
> Note the semicolons.

The problem is that the two forms do not produce the same result.
See Bug #2907028.

If you place the "a=0" inside the plot statement, 
then a really is 0 during the first function evaluation.  
If you place the "a=0" before the plot statement, separated by a semicolon, 
then a has the value 1 during the first function evaluation.
This is, to say the least, unexpected.

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Teo S B. <teo...@gm...>]

2010/2/14 Hans-Bernhard Bröker <HBB...@t-...>:
> Ethan Merritt wrote:
>> On Friday 12 February 2010 11:26:36 Teo S Bernhard wrote:
>>>>> the below shortened example reproducing the error message:
>>>>> # file: trial.gpl
>>>>> f(x)=x
>>>>> plot a=1, \
>>>>>      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
>>>>>      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
>>>>>      a=0
>
> I see no particularly compelling reason why this can't be changed to
>
> a=0 ; plot \
>      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1, \
>      f(x)*a   title "data from index a=2" w l lw 2 lt a ; a = 0
>
> Note the semicolons.
>
> The whole purpose of changing variables' values in the plot command is
> for that to take effect _between_ datasets/functions.  There's no need
> at all for that to be possible before the first, or after the last of them.

Your suggestion breaks  gridding/zooming/... capability in the plot.
This happens because the a-variable is not initiated within the plot statement.
I find when trying:    a=0; plot [0:1] a*x, a=a+1, a*x
- while toggling the grid  I see that the first plot shows '1x' and
2x, while the second version shows: '3x' and '4x'.

Note also that current gnuplot capability _does_ support initial
variable/function initiation, e.g.:    plot [0:1]   a=1, a*x, a=a+1,
a*x
- even according to documentation, see below.

>> So I think you have been depending on undocumented, probably unintended behavior.

The sole issue of mine is that gnuplot version 4.4 rc1 breaks backward
compatibility since it is
 _not_ allowing trailing variable definitions as the last item of
plot-command. Such trailing definitions are
in much use here.

I certainly agree that there are fully functional workarounds even
with the suggested gnuplot 4.4-0 rc1 .
The downside is that any such workaround could imply reworking
historic scripts or other tools that
uses gnuplot as plotting engine and this particular feature. I claim
below - that it is gnuplot 4.4.0 rc1
that is at odds with the documentation.

>
>> What do others think?  Is there good reason to rework the code to allow
>> this, and change the documentation to match?
>

I have been routinely using as _the_plotting_engine since 1999 and I
appreciate your great efforts in maintaining and further improving it.
Whatever your decision, I trust that it will be to the best for the
future of gnuplot.

As to the issue of "trailing definitions", the following is my
argument for why I think that a "trailing definition" should be
allowed:.

I believe that the suggested change is required by the documentation,
I read in gnuplot 4.4 rc 1 under 'help plot':
  a) definitions can come initially in plot command, see the example
no. 3: plot f(x) = sin(x*a), a = .2, f(x), a = .4, f(x)
  b) definitions can come between prior and subsequent functions if
separated by a comma, this is also explicitly said in the help text
  c) In the briefer usage instruction (repeated below) I notice the
optional trailing comma after definitions {,},  I also notice the
replaceable <function>.
  Considering the interpretation of item c), practical experience with
gnuplot versions 4.3, 4.2, 4.0,...,  suggest that there is no need for
a trailing comma after a  definition if there is no trailing
<function>, here <function> can be replaced by nothing. In my opinion,
the latter is a reasonable interpretation which is supported by
historic gnuplot implementations. See the brief usage instruction:
     plot {<ranges>}
             {<iteration>}
             {<function> | {"<datafile>" {datafile-modifiers}}}
             {axes <axes>} {<title-spec>} {with <style>}
             {, {definitions{,}} <function> ...}

My claim is therefore that previous gnuplot version, prior to gnuplot
4.4 rc1, behaved according to this documentation whereas version 4.4
rc 1 does not behave according to the documentation regarding item c,
this causes gnuplot 4.4 rc1 to break backwards compatibility.

If you agree, please consider the following patch vs. gnuplot 4.4 rc1
for allowing trailing definitions in a plot command:  plot [-1:1] k=0,
k*x, k=k+1, k*x, k=k+1
As can be seen, only one code line needs to be modified - in two
places. The modified if-statement is the one that causes an error
message.
With this modification, a trailing definition is silently accepted
whereas earlier syntax errors are triggered as before.

Best regards
Teo
(Linux, Ubuntu 9.10 and self-compiled gnuplot 4.4.0 rc1)


diff -r ca8b5fbc043a plot2d.c
--- a/plot2d.c	Sun Feb 14 14:45:12 2010 +0100
+++ b/plot2d.c	Sun Feb 14 16:45:27 2010 +0100
@@ -1459,7 +1459,7 @@

 	if (is_definition(c_token)) {
 	    define();
-	    if (!equals(c_token,",")) {
+	    if (!END_OF_COMMAND && !equals(c_token,",")) {
 		was_definition = TRUE;
 		continue;
 	    }
@@ -2174,7 +2174,7 @@

 	    if (is_definition(c_token)) {
 		define();
-		if (!equals(c_token,",")) {
+		if (!END_OF_COMMAND && !equals(c_token,",")) {
 		    was_definition = TRUE;
 		    continue;
 		}

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Hans-Bernhard B. <HBB...@t-...>]

Ethan Merritt wrote:
> On Friday 12 February 2010 11:26:36 Teo S Bernhard wrote:

>>>> the below shortened example reproducing the error message:
>>>>
>>>>
>>>> # file: trial.gpl
>>>> f(x)=x
>>>> plot a=1, \
>>>>      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
>>>>      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
>>>>      a=0 

I see no particularly compelling reason why this can't be changed to

a=0 ; plot \
      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1, \
      f(x)*a   title "data from index a=2" w l lw 2 lt a ; a = 0

Note the semicolons.

The whole purpose of changing variables' values in the plot command is 
for that to take effect _between_ datasets/functions.  There's no need 
at all for that to be possible before the first, or after the last of them.

> So I think you have been depending on undocumented, probably unintended,
> behavior.

And there's no need for adding a feature that allows it now.  A 
semicolon instead of the comma achieves the same effect already.

> What do others think?  Is there good reason to rework the code to allow
> this, and change the documentation to match?

IMHO, no.

Re: gnuplot-4.4.0-rc1 breaks gnuplot script (patch)

[sfeam (E. Merritt) <eam...@gm...>]

On Saturday 13 February 2010, Teo S Bernhard wrote:
> On Sat, Feb 13, 2010 at 8:06 PM, Ethan Merritt <merritt@u.washington.edu> wrote:
> > On Saturday 13 February 2010, Teo S Bernhard wrote:
> >> On Fri, Feb 12, 2010 at 7:07 PM, Ethan Merritt <merritt@u.washington.edu> wrote:
> >> > On Friday 12 February 2010 09:58:45 Teo S Bernhard wrote:
> 
> >> I have looked into the code, plot2d.c, regarding this issue. I have a
> >> suggestion for a patch that seems to:
> >> 1)  solve referred Bug #2907028
> >> 2)  also allow trailing assignments to the plot command.
> 
> >> I have tested it on small examples similar to those presented in this thread.
> >> Review and comments on the conceptual idea as presented below in a
> >> diff-form are appreciated.
> >
> > The first pass is used for plotting data,
> > the second pass is used for evaluating functions.
> > If you disable definitions in the first pass,
> > you break plotting from a file.  Consider
> >
> >  plot col=2, 'data' using 1:col with lines
> >
> > If you want to pursue this, you will need to use test cases
> > that mix both function plots and data plots.
> >
> 
> I see , thanks for pointing this out.
> 
> Out of curiosity - is there any way that an approach as the following
> could succeed?
> a) at start of first pass,  copy the the original "namespace(s)" into
> temporary one(s)
> b) use the temporary "namespace(s)" during the first pass
> c) change back to the original "namespace(s)" in the second pass

It could work, yes.  The iteration code already does this for the
iteration variables.  Is there some reason you cannot use the
iteration syntax rather than using a self-modifying definition?

I can think of obscure scenarios that would break your save/restore
procedure. For example, it is possible although convoluted to modify
a variable based on data read during the first pass.  You would lose
the new value after the restore operation.  I don't claim this is a
common thing to do, but we may have to make a decision whether the
gain from re-working the mechanism of handling definitions inside a
plot statement is worth the loss of admittedly rare options for
loading program variables from a data file.

> Since these structures are not an argument to define(), am I right in
> assuming that these are global structures -  of unknown name(s) to me,
> but structures defined in eval.h and eval.c?

User-defined variables are kept in a linked list of structures.
The structure type is udvt_entry.  
The head of the list is (struct udvt_entry *)first_udv.
These are defined in eval.h.

Re: gnuplot-4.4.0-rc1 breaks gnuplot script (patch)

[Teo S B. <teo...@gm...>]

On Sat, Feb 13, 2010 at 8:06 PM, Ethan Merritt <merritt@u.washington.edu> wrote:
> On Saturday 13 February 2010, Teo S Bernhard wrote:
>> On Fri, Feb 12, 2010 at 7:07 PM, Ethan Merritt <merritt@u.washington.edu> wrote:
>> > On Friday 12 February 2010 09:58:45 Teo S Bernhard wrote:

>> I have looked into the code, plot2d.c, regarding this issue. I have a
>> suggestion for a patch that seems to:
>> 1)  solve referred Bug #2907028
>> 2)  also allow trailing assignments to the plot command.

>> I have tested it on small examples similar to those presented in this thread.
>> Review and comments on the conceptual idea as presented below in a
>> diff-form are appreciated.
>
> The first pass is used for plotting data,
> the second pass is used for evaluating functions.
> If you disable definitions in the first pass,
> you break plotting from a file.  Consider
>
>  plot col=2, 'data' using 1:col with lines
>
> If you want to pursue this, you will need to use test cases
> that mix both function plots and data plots.
>

I see , thanks for pointing this out.

Out of curiosity - is there any way that an approach as the following
could succeed?
a) at start of first pass,  copy the the original "namespace(s)" into
temporary one(s)
b) use the temporary "namespace(s)" during the first pass
c) change back to the original "namespace(s)" in the second pass

By "namespace" I mean the structures that hold the variables and
functions that are changed when parsing the plot command,
Particularily, or perhaps only, those changed by the call to define().

Since these structures are not an argument to define(), am I right in
assuming that these are global structures -  of unknown name(s) to me,
but structures defined in eval.h and eval.c?

Thanks for your help.

Re: gnuplot-4.4.0-rc1 breaks gnuplot script (patch)

[Ethan M. <merritt@u.washington.edu>]

On Saturday 13 February 2010, Teo S Bernhard wrote:
> On Fri, Feb 12, 2010 at 7:07 PM, Ethan Merritt <merritt@u.washington.edu> wrote:
> >
> > On Friday 12 February 2010 09:58:45 Teo S Bernhard wrote:
> > > Problem:
> > > Gnuplot script that set parameter repeatedly in plot command to address the
> > > data index (within a data file) does not work when using gnuplot version
> > > 4.4.0-rc1.
> > > It works in 4.2 version and, from memory, did also work in version 4.3. See
> > > the below shortened example reproducing the error message:
> > >
> > >
> > > # file: trial.gpl
> > > f(x)=x
> > > plot a=1, \
> > >      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
> > >      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
> > >      a=0
> >
> > Please see Bug #2907028
> >  https://sourceforge.net/tracker/?func=detail&aid=2907028&group_id=2055&atid=102055
> >
> > So far as I can tell from running old versions of gnuplot (back to 3.7),
> > it never did work correctly to increment a variable multiple times inside
> > a plot command.
> 
> I have looked into the code, plot2d.c, regarding this issue. I have a
> suggestion for a patch that seems to:
> 1)  solve referred Bug #2907028
> 2)  also allow trailing assignments to the plot command.
> 
> There are spurious print-outs in the patch, I have assumed the
> intuitive meaning of END_OF_COMMAND.
> The purpose of the 'was_definition' flag is not clear to me, I set it
> to TRUE always since I belive that the
> result of is_definition(...)  would guarantee this.
> 
> I have tested it on small examples similar to those presented in this thread.
> Review and comments on the conceptual idea as presented below in a
> diff-form are appreciated.

The first pass is used for plotting data, 
the second pass is used for evaluating functions.
If you disable definitions in the first pass, 
you break plotting from a file.  Consider

 plot col=2, 'data' using 1:col with lines

If you want to pursue this, you will need to use test cases
that mix both function plots and data plots.

	Ethan

> 
> Teo
> --------------------------------
> Diff agains gnuplot-4.4.0-rc1, 'hg diff' was run in ./src-directory:
> 
> diff -r 9c57e57e6e92 plot2d.c
> --- a/plot2d.c	Fri Feb 12 22:35:43 2010 +0100
> +++ b/plot2d.c	Sat Feb 13 14:23:04 2010 +0100
> @@ -1457,12 +1457,29 @@
>  	    newhist_pattern = fs.fillpattern;
>  	} else
> 
> -	if (is_definition(c_token)) {
> -	    define();
> -	    if (!equals(c_token,",")) {
> -		was_definition = TRUE;
> -		continue;
> -	    }
> +        if (is_definition(c_token)) {   /*skip over definitions in first pass*/
> +          if (1==0){ /*original version that evaluate definitions
> also in first pass*/
> +            printf("fp: original: definition for c_token: %i\n", c_token);
> +            define();
> +            printf("fp: original:         done,  c_token: %i\n", c_token);
> +            if (!equals(c_token,",")) {
> +                 was_definition = TRUE;
> +                 continue;
> +            }
> +          }
> +          else { /*modified version that skips definitions in first pass*/
> +            was_definition = TRUE;
> +            printf("fp: modified: definition for c_token: %i\n", c_token);
> +            while(!END_OF_COMMAND && !equals(c_token,",")){
> +              c_token++;
> +            }
> +            printf("fp: modified:         done,  c_token: %i\n", c_token);
> +            if (END_OF_COMMAND){
> +              printf("fp: END_OF_COMMAND: %i\n", END_OF_COMMAND);
> +              break;
> +            }
> +          }
> +
> 
>  	} else {
>  	    int specs = 0;
> @@ -2172,12 +2189,28 @@
>  	    if (!in_parametric && !was_definition)
>  		start_token = c_token;
> 
> -	    if (is_definition(c_token)) {
> +	    if (is_definition(c_token)) { /*do definitions on second pass */
> +	      if (1==0){ /*original version*/
> +		printf("sp: original: definition for c_token: %i\n", c_token);
>  		define();
> +		printf("sp: original:         done,  c_token: %i\n", c_token);
>  		if (!equals(c_token,",")) {
>  		    was_definition = TRUE;
>  		    continue;
>  		}
> +	      }
> +	      else { /*modified version does definitions and allows a trailing one*/
> +		printf("sp: modified: definition for c_token: %i\n", c_token);
> +		define();
> +		was_definition = TRUE;
> +		printf("sp: modified:         done,  c_token: %i\n", c_token);
> +		if (END_OF_COMMAND){
> +		  printf("sp: END_OF_COMMAND: %i\n", END_OF_COMMAND);
> +		  break;
> +		}
> +	      }
> +
> +
> 
>  	    } else {
>  		struct at_type *at_ptr;
> 
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
> 

Re: gnuplot-4.4.0-rc1 breaks gnuplot script (patch)

[Teo S B. <teo...@gm...>]

Some test cases:

#testcase: try01
set grid
set key left
set samples 10
set title "try01: parameter definition both in front and trailing"
plot [0:1] [-1:10]           k=0,     \
    k*x t '0x'  w lp lt 3,   k=k+1,   \
    k*x t '1x'  w lp lt 4,   k=k+1,   \
    k*x t '2x'  w lp lt 5,   k=k+1

pause -1 "Continue?"
print "k=3?", " k=", k

#testcase: try02
set grid
set key left
set samples 10
set title "try02: parameter definiton, notice recalculation on zoom/replot"
k=0
plot [0:1] [-1:10]                    \
    k*x t '0x'  w lp lt 3,   k=k+1,   \
    k*x t '1x'  w lp lt 4,   k=k+1,   \
    k*x t '2x'  w lp lt 5,   k=k+1

pause -1 "Continue?"
print "k=", k


#testcase: try03
set grid
set title "try03: parameter and function definitions, notice enhanced labels"
plot [-10:10] [-200:200]   k=10, k*x ,                 \
                           a=10,b=2,f(x)=a*b*x, f(x)
pause -1 "Continue?"
print "k=", k, " a=", a, " b=",b

#testcase: try04
set grid
set title "try04: mix of parameter definiton and iteration"
plot [-10:10] [-30:30] a=3, a*x, for [k=1:2] k*x
pause -1 "Continue?"
print "a=", a

exit

#testcase: try05 (causes unresponsive gnuplot)
set grid
set title "try05: infinite loop?"
plot [-10:10] [-30:30] a=3, a*x, a=7, for [k=1:2] k*x
pause -1 "Continue?"
print "a=", a

Re: gnuplot-4.4.0-rc1 breaks gnuplot script (patch)

[Teo S B. <teo...@gm...>]

On Fri, Feb 12, 2010 at 7:07 PM, Ethan Merritt <merritt@u.washington.edu> wrote:
>
> On Friday 12 February 2010 09:58:45 Teo S Bernhard wrote:
> > Problem:
> > Gnuplot script that set parameter repeatedly in plot command to address the
> > data index (within a data file) does not work when using gnuplot version
> > 4.4.0-rc1.
> > It works in 4.2 version and, from memory, did also work in version 4.3. See
> > the below shortened example reproducing the error message:
> >
> >
> > # file: trial.gpl
> > f(x)=x
> > plot a=1, \
> >      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
> >      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
> >      a=0
>
> Please see Bug #2907028
>  https://sourceforge.net/tracker/?func=detail&aid=2907028&group_id=2055&atid=102055
>
> So far as I can tell from running old versions of gnuplot (back to 3.7),
> it never did work correctly to increment a variable multiple times inside
> a plot command.

I have looked into the code, plot2d.c, regarding this issue. I have a
suggestion for a patch that seems to:
1)  solve referred Bug #2907028
2)  also allow trailing assignments to the plot command.

There are spurious print-outs in the patch, I have assumed the
intuitive meaning of END_OF_COMMAND.
The purpose of the 'was_definition' flag is not clear to me, I set it
to TRUE always since I belive that the
result of is_definition(...)  would guarantee this.

I have tested it on small examples similar to those presented in this thread.
Review and comments on the conceptual idea as presented below in a
diff-form are appreciated.

Teo
--------------------------------
Diff agains gnuplot-4.4.0-rc1, 'hg diff' was run in ./src-directory:

diff -r 9c57e57e6e92 plot2d.c
--- a/plot2d.c	Fri Feb 12 22:35:43 2010 +0100
+++ b/plot2d.c	Sat Feb 13 14:23:04 2010 +0100
@@ -1457,12 +1457,29 @@
 	    newhist_pattern = fs.fillpattern;
 	} else

-	if (is_definition(c_token)) {
-	    define();
-	    if (!equals(c_token,",")) {
-		was_definition = TRUE;
-		continue;
-	    }
+        if (is_definition(c_token)) {   /*skip over definitions in first pass*/
+          if (1==0){ /*original version that evaluate definitions
also in first pass*/
+            printf("fp: original: definition for c_token: %i\n", c_token);
+            define();
+            printf("fp: original:         done,  c_token: %i\n", c_token);
+            if (!equals(c_token,",")) {
+                 was_definition = TRUE;
+                 continue;
+            }
+          }
+          else { /*modified version that skips definitions in first pass*/
+            was_definition = TRUE;
+            printf("fp: modified: definition for c_token: %i\n", c_token);
+            while(!END_OF_COMMAND && !equals(c_token,",")){
+              c_token++;
+            }
+            printf("fp: modified:         done,  c_token: %i\n", c_token);
+            if (END_OF_COMMAND){
+              printf("fp: END_OF_COMMAND: %i\n", END_OF_COMMAND);
+              break;
+            }
+          }
+

 	} else {
 	    int specs = 0;
@@ -2172,12 +2189,28 @@
 	    if (!in_parametric && !was_definition)
 		start_token = c_token;

-	    if (is_definition(c_token)) {
+	    if (is_definition(c_token)) { /*do definitions on second pass */
+	      if (1==0){ /*original version*/
+		printf("sp: original: definition for c_token: %i\n", c_token);
 		define();
+		printf("sp: original:         done,  c_token: %i\n", c_token);
 		if (!equals(c_token,",")) {
 		    was_definition = TRUE;
 		    continue;
 		}
+	      }
+	      else { /*modified version does definitions and allows a trailing one*/
+		printf("sp: modified: definition for c_token: %i\n", c_token);
+		define();
+		was_definition = TRUE;
+		printf("sp: modified:         done,  c_token: %i\n", c_token);
+		if (END_OF_COMMAND){
+		  printf("sp: END_OF_COMMAND: %i\n", END_OF_COMMAND);
+		  break;
+		}
+	      }
+
+

 	    } else {
 		struct at_type *at_ptr;

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Tatsuro M. <tma...@ya...>]

Hello

--- Ethan Merritt  wrote:

> > k=0
> > plot [0:1] [-1:]             k=0,   \
> >     k*x t '0x'  w lp lt 1,   k=k+1, \
> >     k*x t '1x' w lp  lt 2,   k=k+1, \
> >     k*x t '2x' w lp  lt 3
> > 
> > Now, if you remove the initial 'k=0, \' part of the plot-command - the
> > '0x'-line is plotted as 2*x, the '1x'-line as 3*x and '2x'-line as 4*x. Can
> > this be related to the two 'k=k+1' for some strange reason? In deed, adding
> > a third 'k=k+1' leads the first '0x'-line to be plotted as 3*x!  This is
> > clearly a bug since k is expected as zero for the first line to be plotted,
> > '0x'.
> > 
> > I therefore think there are two issues here:
> > 1) The issue reported as Bug #2907028 and
> > 2) the issue reported by me here, that version 4.4 does not allow an
> > increment as the last statement of a plot-command.
> 
> The 4.0 and 4.2 documentation gives:
>  Syntax:
>        plot {<ranges>}
>             {<function> | {"<datafile>" {datafile-modifiers}}}
>             {axes <axes>} {<title-spec>} {with <style>}
>             {, {definitions,} <function> ...}
> 
> which means that definitions can come before a function, but not after.
> So I think you have been depending on undocumented, probably unintended,
> behavior.
> 
> It may well be that some earlier versions did accept a trailing
> definition, but since it was not documented no one was testing for this
> as the code evolved.
> 
> If there were no better way to accomplish what you were doing, I would
> agree that it was a bug and should be fixed.  But since this can now be
> done more conveniently in 4.4 using iteration, I don't see much incentive
> to go back and reconstruct how earlier versions worked on an undocumented
> command syntax.
> 
> What do others think?  Is there good reason to rework the code to allow
> this, and change the documentation to match?
> 
> 	Ethan

I have not know the such syntax can be used for gnuplot. I have been used external awk script, which
produce the gnuplot scripts,  if iteration has been required.

The iteration feature of 4.4 is very nice and useful.  In my idea, the old undocumented syntax needs
not to be fixed because there appears more convenient implementation for iteration.  If one would like
to use the syntax, the fix should be done by oneself.

Regards

Tatsuro
  

--------------------------------------
VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
http://pr.mail.yahoo.co.jp/olympic/

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Ethan M. <merritt@u.washington.edu>]

On Friday 12 February 2010 11:26:36 Teo S Bernhard wrote:

> > > the below shortened example reproducing the error message:
> > >
> > >
> > > # file: trial.gpl
> > > f(x)=x
> > > plot a=1, \
> > >      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
> > >      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
> > >      a=0
> >
> > Please see Bug #2907028
> >
> > https://sourceforge.net/tracker/?func=detail&aid=2907028&group_id=2055&atid=102055
> >
> > So far as I can tell from running old versions of gnuplot (back to 3.7),
> > it never did work correctly to increment a variable multiple times inside
> > a plot command.
> >
> >
> Test of referred bug report:
> I have tested and it is is reproducible. There is however a subtle
> difference with my example and that  of the bug report. Note that I initiate
> the counter variable first in the plot command. Then - the problem vanish.
> The parameter incrementation is then correct!
> You can convince yourself by trying the following:
> 
> k=0
> plot [0:1] [-1:]             k=0,   \
>     k*x t '0x'  w lp lt 1,   k=k+1, \
>     k*x t '1x' w lp  lt 2,   k=k+1, \
>     k*x t '2x' w lp  lt 3
> 
> Now, if you remove the initial 'k=0, \' part of the plot-command - the
> '0x'-line is plotted as 2*x, the '1x'-line as 3*x and '2x'-line as 4*x. Can
> this be related to the two 'k=k+1' for some strange reason? In deed, adding
> a third 'k=k+1' leads the first '0x'-line to be plotted as 3*x!  This is
> clearly a bug since k is expected as zero for the first line to be plotted,
> '0x'.
> 
> I therefore think there are two issues here:
> 1) The issue reported as Bug #2907028 and
> 2) the issue reported by me here, that version 4.4 does not allow an
> increment as the last statement of a plot-command.

The 4.0 and 4.2 documentation gives:
 Syntax:
       plot {<ranges>}
            {<function> | {"<datafile>" {datafile-modifiers}}}
            {axes <axes>} {<title-spec>} {with <style>}
            {, {definitions,} <function> ...}

which means that definitions can come before a function, but not after.
So I think you have been depending on undocumented, probably unintended,
behavior.

It may well be that some earlier versions did accept a trailing
definition, but since it was not documented no one was testing for this
as the code evolved.

If there were no better way to accomplish what you were doing, I would
agree that it was a bug and should be fixed.  But since this can now be
done more conveniently in 4.4 using iteration, I don't see much incentive
to go back and reconstruct how earlier versions worked on an undocumented
command syntax.

What do others think?  Is there good reason to rework the code to allow
this, and change the documentation to match?

	Ethan


> 
> This test on Ubuntu 8.04, gnuplot 4.2 patchlevel  2 and  gnuplot 4.3
> patchlevel  0.
> 
> > pause -1 "Continue?"
> > >
> > > #
> > > # gnuplot 4.2 patchlevel 5 accepts the above. I believe that also
> > > # gnuplot 4.3 accepted this.
> > > #
> > > # gnuplot-4.4.0 patchlevel 0-rc1 give error:
> > > #    "trial.gpl", line 6: function to plot expected
> > > #
> > > #
> > > #  It works if I add a dummy curve after a=0, so that last line
> > > #  becomes:
> > > #                   a=0, x/0
> > > #
> > > exit
> > >
> > > Best regards
> > > Teo
> > >
> >
> >

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Teo S B. <teo...@gm...>]

On Fri, Feb 12, 2010 at 7:07 PM, Ethan Merritt <merritt@u.washington.edu>wrote:

> On Friday 12 February 2010 09:58:45 Teo S Bernhard wrote:
> > Problem:
> > Gnuplot script that set parameter repeatedly in plot command to address
> the
> > data index (within a data file) does not work when using gnuplot version
> > 4.4.0-rc1.
> > It works in 4.2 version and, from memory, did also work in version 4.3.
> See
> > the below shortened example reproducing the error message:
> >
> >
> > # file: trial.gpl
> > f(x)=x
> > plot a=1, \
> >      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
> >      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
> >      a=0
>
> Please see Bug #2907028
>
> https://sourceforge.net/tracker/?func=detail&aid=2907028&group_id=2055&atid=102055
>
> So far as I can tell from running old versions of gnuplot (back to 3.7),
> it never did work correctly to increment a variable multiple times inside
> a plot command.
>
>
Test of referred bug report:
I have tested and it is is reproducible. There is however a subtle
difference with my example and that  of the bug report. Note that I initiate
the counter variable first in the plot command. Then - the problem vanish.
The parameter incrementation is then correct!
You can convince yourself by trying the following:

k=0
plot [0:1] [-1:]             k=0,   \
    k*x t '0x'  w lp lt 1,   k=k+1, \
    k*x t '1x' w lp  lt 2,   k=k+1, \
    k*x t '2x' w lp  lt 3

Now, if you remove the initial 'k=0, \' part of the plot-command - the
'0x'-line is plotted as 2*x, the '1x'-line as 3*x and '2x'-line as 4*x. Can
this be related to the two 'k=k+1' for some strange reason? In deed, adding
a third 'k=k+1' leads the first '0x'-line to be plotted as 3*x!  This is
clearly a bug since k is expected as zero for the first line to be plotted,
'0x'.

I therefore think there are two issues here:
1) The issue reported as Bug #2907028 and
2) the issue reported by me here, that version 4.4 does not allow an
increment as the last statement of a plot-command.

This test on Ubuntu 8.04, gnuplot 4.2 patchlevel  2 and  gnuplot 4.3
patchlevel  0.

> pause -1 "Continue?"
> >
> > #
> > # gnuplot 4.2 patchlevel 5 accepts the above. I believe that also
> > # gnuplot 4.3 accepted this.
> > #
> > # gnuplot-4.4.0 patchlevel 0-rc1 give error:
> > #    "trial.gpl", line 6: function to plot expected
> > #
> > #
> > #  It works if I add a dummy curve after a=0, so that last line
> > #  becomes:
> > #                   a=0, x/0
> > #
> > exit
> >
> > Best regards
> > Teo
> >
>
>

Re: gnuplot-4.4.0-rc1 breaks gnuplot script

[Ethan M. <merritt@u.washington.edu>]

On Friday 12 February 2010 09:58:45 Teo S Bernhard wrote:
> Problem:
> Gnuplot script that set parameter repeatedly in plot command to address the
> data index (within a data file) does not work when using gnuplot version
> 4.4.0-rc1.
> It works in 4.2 version and, from memory, did also work in version 4.3. See
> the below shortened example reproducing the error message:
> 
> 
> # file: trial.gpl
> f(x)=x
> plot a=1, \
>      f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
>      f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
>      a=0

Please see Bug #2907028
  https://sourceforge.net/tracker/?func=detail&aid=2907028&group_id=2055&atid=102055

So far as I can tell from running old versions of gnuplot (back to 3.7),
it never did work correctly to increment a variable multiple times inside
a plot command.

The good news is that in version 4.4 you can do this easily using the construct
   plot for [a=1:2] f(x)*a   title "data from index a=1" w l lw 2 lt a


> pause -1 "Continue?"
> 
> #
> # gnuplot 4.2 patchlevel 5 accepts the above. I believe that also
> # gnuplot 4.3 accepted this.
> #
> # gnuplot-4.4.0 patchlevel 0-rc1 give error:
> #    "trial.gpl", line 6: function to plot expected
> #
> #
> #  It works if I add a dummy curve after a=0, so that last line
> #  becomes:
> #                   a=0, x/0
> #
> exit
> 
> Best regards
> Teo
> 



-- 
Ethan A Merritt
Biomolecular Structure Center
University of Washington, Seattle 98195-7742

gnuplot-4.4.0-rc1 breaks gnuplot script

[Teo S B. <teo...@gm...>]

Problem:
Gnuplot script that set parameter repeatedly in plot command to address the
data index (within a data file) does not work when using gnuplot version
4.4.0-rc1.
It works in 4.2 version and, from memory, did also work in version 4.3. See
the below shortened example reproducing the error message:


# file: trial.gpl
f(x)=x
plot a=1, \
     f(x)*a   title "data from index a=1" w l lw 2 lt a ,  a=a+1,       \
     f(x)*a   title "data from index a=2" w l lw 2 lt a ,  a=a+1,       \
     a=0

pause -1 "Continue?"

#
# gnuplot 4.2 patchlevel 5 accepts the above. I believe that also
# gnuplot 4.3 accepted this.
#
# gnuplot-4.4.0 patchlevel 0-rc1 give error:
#    "trial.gpl", line 6: function to plot expected
#
#
#  It works if I add a dummy curve after a=0, so that last line
#  becomes:
#                   a=0, x/0
#
exit

Best regards
Teo

Re: htlatex?? in docs/Makefile.in in cvs source ( 2010-02-11)

[Tatsuro M. <tma...@ya...>]

--- Ethan Merritt  wrote:

> For me latex2html no longer works.  See for instance the recent bug
> report  
>   https://sourceforge.net/tracker/?func=detail&aid=2949058&group_id=2055&atid=102055
> 
> Latex2html has been unsupported since 2001 (9 years ago).
> I have tried various possible replacements, but htlatex is the first
> one I have found that actually works.
> 
> If you have a different tool chain that works, by all means use it.
> I don't really expect that every user will need to make the html
> documentation or the html version of the demos, so I think it is
> OK if the Makefiles require a bit of local customization.

Thank you for explanation. I understand the situation.
I'll try htlatex but I'll continue to use latex2html with local change of Makefile for a while.

Regards

Tatsuro 

--------------------------------------
VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
http://pr.mail.yahoo.co.jp/olympic/

Re: htlatex?? in docs/Makefile.in in cvs source ( 2010-02-11)

[Ethan M. <merritt@u.washington.edu>]

On Thursday 11 February 2010, Tatsuro MATSUOKA wrote:
> Hello
> 
> I could not make the html documents from latex in cvs source ( 2010-02-11) on cygwin
> 
> $ CC='gcc-4 -shared-libgcc' CXX='g++-4 -shared-libgcc' CFLAGS='-O3 -fomit-frame-pointer' CXXFLAGS='-O3
> -fomit-frame-pointer' make html
> rm -f VERSION; ln -s ../VERSION .
> htlatex gnuplot
> make: htlatex: Command not found
> make: *** [htmldocs/gnuplot.html] Error 127
> 
> I have a look into docs/Makefile.in
> 
> # requires a working latex2html, which is hard to find these days
> # htmldocs/gnuplot.html: $(srcdir)/gnuplot.tex
> #	mkdir -p htmldocs
> #	latex2html -dir htmldocs -local_icons gnuplot
> 
> htmldocs/gnuplot.html: $(srcdir)/gnuplot.dvi
> 	rm -f VERSION; ln -s ../VERSION .
> 	htlatex gnuplot
> 	mkdir -p htmldocs
> 	mv gnuplot.html gnuplot.css gnuplot*.png gnuplot.log htmldocs/
> 
> It seemed that latex2html is disabled but one has to use htlatex.
> 
> I have googled htlatex but good information have not been obtained yet. 
> 
> Any suggestions?
> 
> Meanwhile I am using latex2html until I will be able to use htlatex.

For me latex2html no longer works.  See for instance the recent bug
report  
  https://sourceforge.net/tracker/?func=detail&aid=2949058&group_id=2055&atid=102055

Latex2html has been unsupported since 2001 (9 years ago).
I have tried various possible replacements, but htlatex is the first
one I have found that actually works.

If you have a different tool chain that works, by all means use it.
I don't really expect that every user will need to make the html
documentation or the html version of the demos, so I think it is
OK if the Makefiles require a bit of local customization.

	Ethan



> 
> Regards
> 
> Tatsuro
> 
> 
> 
> --------------------------------------
> VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
> http://pr.mail.yahoo.co.jp/olympic/
> 
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
> 

htlatex?? in docs/Makefile.in in cvs source ( 2010-02-11)

[Tatsuro M. <tma...@ya...>]

Hello

I could not make the html documents from latex in cvs source ( 2010-02-11) on cygwin

$ CC='gcc-4 -shared-libgcc' CXX='g++-4 -shared-libgcc' CFLAGS='-O3 -fomit-frame-pointer' CXXFLAGS='-O3
-fomit-frame-pointer' make html
rm -f VERSION; ln -s ../VERSION .
htlatex gnuplot
make: htlatex: Command not found
make: *** [htmldocs/gnuplot.html] Error 127

I have a look into docs/Makefile.in

# requires a working latex2html, which is hard to find these days
# htmldocs/gnuplot.html: $(srcdir)/gnuplot.tex
#	mkdir -p htmldocs
#	latex2html -dir htmldocs -local_icons gnuplot

htmldocs/gnuplot.html: $(srcdir)/gnuplot.dvi
	rm -f VERSION; ln -s ../VERSION .
	htlatex gnuplot
	mkdir -p htmldocs
	mv gnuplot.html gnuplot.css gnuplot*.png gnuplot.log htmldocs/

It seemed that latex2html is disabled but one has to use htlatex.

I have googled htlatex but good information have not been obtained yet. 

Any suggestions?

Meanwhile I am using latex2html until I will be able to use htlatex.

Regards

Tatsuro



--------------------------------------
VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
http://pr.mail.yahoo.co.jp/olympic/

Re: towards 4.4 (ctrl+c issue for gnuplot.exe(windows))

[Tatsuro M. <tma...@ya...>]

Hello

Sorry I have still misled.

    term_reset();
    (void) putc('\n', stderr);
    bail_to_command_line();	/* return to prompt */

If, for example, I modify 
    (void) putc('\n', stderr);
    char buf[256];
    fgets(buf, strlen(buf), stdin);
    bail_to_command_line();	/* return to prompt */


    fgets(buf, strlen(buf), stdin);
is ignored. That is a problem.
I have tried term->waitforinput(), the result was the same.

Regards

Tatsuro

--- Tatsuro MATSUOKA  wrote:

> Hello
> 
> I have traced this issue.
> --- Ethan Merritt wrote:
> > > ****************
> > > --- gnuplot-4.3.0-2009-07-08-orig/src/plot.c	2009-09-20 20:16:47 +0200
> > > +++ gnuplot-4.3.0-2009-07-08/src/plot.c	2009-10-18 13:06:08 +0200
> > > @@ -684,7 +684,11 @@
> > >      setmatherr(purec_matherr);
> > >  #endif
> > >  
> > > +#if defined(WGP_CONSOLE)
> > > +    (void) signal(SIGINT, SIG_IGN);
> > > +#else
> > >      (void) signal(SIGINT, (sigfunc) inter);
> > > +#endif
> > >  
> > >  #ifdef SIGPIPE
> > >      /* ignore pipe errors, this might happen with set output "|head" */
> > > ******************
> 
> I have completely misunderstood the situation.  The (void) signal(SIGINT, (sigfunc) inter);
> works on
> gnuplot.exe. Pressing CTRL+C, inter(int anint) was surely called.
> 
> In the function 'inter', the below exist
> 
>     term_reset();
>     (void) putc('\n', stderr);
>     bail_to_command_line();	/* return to prompt */
> 
> #####
> The upper two 
>     term_reset();
>     (void) putc('\n', stderr);
> 
> was executed correctly and fails at     bail_to_command_line();.
> 
> bail_to_command_line() is described as
> 
> void
> bail_to_command_line()
> {
> #ifdef _Windows
>     call_kill_pending_Pause_dialog();
> #endif
>     LONGJMP(command_line_env, TRUE);
> }
>  
> call_kill_pending_Pause_dialog(); exist in commnand.c, and it just call the function
> kill_pending_Pause_dialog(); in the following in winmain.c
> 
> ***
> void
> kill_pending_Pause_dialog ()
> {
> 	if (pausewin.bPause == FALSE) /* no Pause dialog displayed */
> 	    return;
> 	/* Pause dialog displayed, thus kill it */
> 	DestroyWindow(pausewin.hWndPause);
> #ifndef WIN32
> #ifndef __DLL__
> 	FreeProcInstance((FARPROC)pausewin.lpfnPauseButtonProc);
> #endif
> #endif
> 	pausewin.bPause = FALSE;
> }
> 
> 
> Obviously, kill_pending_Pause_dialog() has no meaning for gnuplot.exe.
> 
> I have quickly tried to modify bail_to_command_line() and , 
> 
> bail_to_command_line()
> {
> #if defined(_Windows) && !defined(WGP_CONSOLE)
>     call_kill_pending_Pause_dialog();
> #endif
>     LONGJMP(command_line_env, TRUE);
> }
> 
> However, gnuplot.exe still hangs up. 
> 
>     LONGJMP(command_line_env, TRUE);
> 
> seems not work for windows console mode.
> 
> Perhaps, the above things have known but I have noticed this time.
> 
> Any suggestions?
> 
> Regards
> 
> Tatsuro
> 
> 
> 
> 
> --------------------------------------
> VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
> http://pr.mail.yahoo.co.jp/olympic/
> 
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
> 


--------------------------------------
VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
http://pr.mail.yahoo.co.jp/olympic/

Re: towards 4.4 (ctrl+c issue for gnuplot.exe(windows))

[Tatsuro M. <tma...@ya...>]

Hello

I have traced this issue.
--- Ethan Merritt wrote:
> > ****************
> > --- gnuplot-4.3.0-2009-07-08-orig/src/plot.c	2009-09-20 20:16:47 +0200
> > +++ gnuplot-4.3.0-2009-07-08/src/plot.c	2009-10-18 13:06:08 +0200
> > @@ -684,7 +684,11 @@
> >      setmatherr(purec_matherr);
> >  #endif
> >  
> > +#if defined(WGP_CONSOLE)
> > +    (void) signal(SIGINT, SIG_IGN);
> > +#else
> >      (void) signal(SIGINT, (sigfunc) inter);
> > +#endif
> >  
> >  #ifdef SIGPIPE
> >      /* ignore pipe errors, this might happen with set output "|head" */
> > ******************

I have completely misunderstood the situation.  The (void) signal(SIGINT, (sigfunc) inter); works on
gnuplot.exe. Pressing CTRL+C, inter(int anint) was surely called.

In the function 'inter', the below exist

    term_reset();
    (void) putc('\n', stderr);
    bail_to_command_line();	/* return to prompt */

#####
The upper two 
    term_reset();
    (void) putc('\n', stderr);

was executed correctly and fails at     bail_to_command_line();.

bail_to_command_line() is described as

void
bail_to_command_line()
{
#ifdef _Windows
    call_kill_pending_Pause_dialog();
#endif
    LONGJMP(command_line_env, TRUE);
}
 
call_kill_pending_Pause_dialog(); exist in commnand.c, and it just call the function
kill_pending_Pause_dialog(); in the following in winmain.c

***
void
kill_pending_Pause_dialog ()
{
	if (pausewin.bPause == FALSE) /* no Pause dialog displayed */
	    return;
	/* Pause dialog displayed, thus kill it */
	DestroyWindow(pausewin.hWndPause);
#ifndef WIN32
#ifndef __DLL__
	FreeProcInstance((FARPROC)pausewin.lpfnPauseButtonProc);
#endif
#endif
	pausewin.bPause = FALSE;
}


Obviously, kill_pending_Pause_dialog() has no meaning for gnuplot.exe.

I have quickly tried to modify bail_to_command_line() and , 

bail_to_command_line()
{
#if defined(_Windows) && !defined(WGP_CONSOLE)
    call_kill_pending_Pause_dialog();
#endif
    LONGJMP(command_line_env, TRUE);
}

However, gnuplot.exe still hangs up. 

    LONGJMP(command_line_env, TRUE);

seems not work for windows console mode.

Perhaps, the above things have known but I have noticed this time.

Any suggestions?

Regards

Tatsuro




--------------------------------------
VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
http://pr.mail.yahoo.co.jp/olympic/

Re: Parsing bug?

[Ethan M. <merritt@u.washington.edu>]

On Tuesday 09 February 2010, Thomas Sefzick wrote:
> 
> this has been repaired in the development version of gnuplot:

>         G N U P L O T
>         Version 4.4 patchlevel 0-rc1
> gnuplot> print 6000**4
> -2086600704
> 
> 
>         G N U P L O T
>         Version 4.5 patchlevel 0
> gnuplot> print 6000**4
> 1.296e+15

Just to keep everyone on the same page...

The code base for the 4.4 was basically frozen at the time the
time the 4.4.0-rc1 snapshot was created.  Since then I've only
applied bug fixes, particularly for problems reported against -rc1.

I have kept a set of patches against 4.5 CVS to be applied to 
4.4 CVS once 4.4.0 is out the door.  So I expect these will appear
in 4.4.1:

   winmain_va_copy      Allows building with Visual C
   wxt_dashed           set term wxt ... {dashed|solid} {dashlength <dl>}
   x11_mousewheel		mousewheel support
   wxt_mousewheel		mousewheel support
   pow_overflow         if i**j would cause integer overflow, return a float instead
   int_overflow         Check internal integer multiplications for overflow
   tikz                 remove conditional tests for version 4.3
   candle_width         optional 6th column containing box width
   rmargin              tweak left and right margins to be more like those prior to 4.2.4
   jw-refactor          clean up the execute-from-string operations lf_push/lf_pop
   cc-for-build         fix for building documentation during cross-compilation
   percent_s            support the "%s" format specifier in strftime()
   Kalinin_metapost     Fix inheritance of line thickness by text strings
   suppress_PDFMark     rearrange postscript prolog to allow customization
   timefmt              handle evaluated input values for time format "%s"
   init_func_points     initialize full coordinate structure for 2D functions

Re: Add 'size' and 'position' to windows terminal options

[Tatsuro M. <tma...@ya...>]

Hello

--- Ethan Merritt  wrote:

> > --- Ethan Merritt  wrote:
> > 
> > > The only patch I see in the ChangeLogs that might explain this is the one from
> > > Shige Takeno applied to 4.5 CVS 30-Dec-2009.   I have now applied that same patch 
> > > to the 4.4 CVS source as well.   Please see if that fixes the problem.
> > > 
> > > 	Ethan
> > 
> > I have attached the patch by Shige Takeno applied to 4.5 CVS 30-Dec-2009 is applied.
> > http://sourceforge.net/tracker/?func=detail&aid=2918370&group_id=2055&atid=302055
> > 
> > After that I attached the Benjamin's  patches. 
> > The 'size' and 'position' to windows terminal options worked correctly.
> > 
> > 
> > BTW,  how can I access the 4.4 CVS source?
> 
> Same root repository, but a special branch label
> 
>   CVSROOT=:pserver:ano...@gn...:/cvsroot/gnuplot
>   cvs login
>   cvs co -r branch-4-4-stable gnuplot

I have been able to access the branch-4-4-stable cvs source and test the Benjamin's patches.
It worked fine as you indicated.

Thanks!!

Tatsuro

--------------------------------------
VANCOUVER 2010 Olympic News [Yahoo! Sports/sportsnavi]
http://pr.mail.yahoo.co.jp/olympic/

Re: install TkiZ terminal gnuplot-4.4.0-rc1

[Ethan M. <merritt@u.washington.edu>]

On Tuesday 09 February 2010, Allin Cottrell wrote:
> 
> On Tue, 9 Feb 2010, gerion wrote:
> 
> > Thanks for the quick response. Can't find it in the INSTALL though.
> > now the terminal gets installed, but doesn't seem to work properly. The
> > "./configure --with-lua yes" gives
> >
> > checking for LUA... yes
> > checking for library containing luaL_openlibs... none required
> > checking lua.h usability... no
> > checking lua.h presence... no
> > checking for lua.h... no
> > configure: WARNING: please add path to lua.h to CPPFLAGS in Makefile
> >
> > however, the Makefile contains "CPPFLAGS =   -I/usr/include/lua5.1" which
> > has the lua.h
> 
> I'd have thought that CFLAGS would be more relevant than CPPFLAGS.

Not in this case.  The problem (if it is one) is with #include statements.
They are handled by cpp.   But in fact it is only a warning, and apparently
"make" then succeeds.  So I think we're OK.

	Ethan



> Allin Cottrell
> 
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
> 

Re: install TkiZ terminal gnuplot-4.4.0-rc1

[Ethan M. <merritt@u.washington.edu>]

On Tuesday 09 February 2010 15:26:41 gerion wrote:
> 
> Thanks for the quick response. Can't find it in the INSTALL though.

Right. The note has been added for inclusion in the 4.4.0 release based on
feedback from the release candidate.

> now the terminal gets installed, but doesn't seem to work properly. The
> "./configure --with-lua yes" gives
> 
> checking for LUA... yes
> checking for library containing luaL_openlibs... none required
> checking lua.h usability... no
> checking lua.h presence... no
> checking for lua.h... no
> configure: WARNING: please add path to lua.h to CPPFLAGS in Makefile
> 
> however, the Makefile contains "CPPFLAGS =   -I/usr/include/lua5.1" which
> has the lua.h

That warning is from the configure script, not from make.
I would have expected make to succeed if CPPFLAGS is correct.
If "make" fails, could you attach the error messages?

	Ethan

> 
> Cheers, Christian
> -- 
> View this message in context: http://old.nabble.com/install-TkiZ-terminal-gnuplot-4.4.0-rc1-tp27479233p27523924.html
> Sent from the Gnuplot - Dev mailing list archive at Nabble.com.
> 
> 
> ------------------------------------------------------------------------------
> SOLARIS 10 is the OS for Data Centers - provides features such as DTrace,
> Predictive Self Healing and Award Winning ZFS. Get Solaris 10 NOW
> http://p.sf.net/sfu/solaris-dev2dev
> _______________________________________________
> gnuplot-beta mailing list
> gnu...@li...
> https://lists.sourceforge.net/lists/listinfo/gnuplot-beta
> 



-- 
Ethan A Merritt
Biomolecular Structure Center
University of Washington, Seattle 98195-7742