Git Repository Merge Request #17: Include bitmap terminals by default, but not dot-matrix printers (open)
Merging...
Merged
Something went wrong. Please, merge manually
Checking if merge is possible...
Something went wrong. Please, merge manually
Bastian Märkisch wants to merge 1 commit from /u/markisch/gnuplot/ to master, 2021-12-20
One of the original motivations to disable bitmap terminals by default
was bitmap.c's license and that these terminals had seriously fallen
behind or just weren't useful anymore. Since the license changed, and the
bitmap terminals sixeltek and block can be useful, we now default to
enable bitmap terminals again. We add a new option "--with-old-printers"
to include terminals for old dot-matrix printers.
| Commit | Date | |
|---|---|---|
|
[7dec9f]
(bitmap-enable)
by
Bastian Maerkisch
Include bitmap terminals by default, but not old dot-matrix printers One of the original reasons to disable bitmap terminals by default |
2021-07-16 07:06:54 | Tree |
@sfeam, is this change acceptable? I would really like the block terminal to be included by default.
I admit to being very "old school" in coding preferences. Smaller is better; deleting code is better than adding code; new code should be justified by demonstrating that it satisfies a need that is not well-served without it. My personal feeling is that none of the terminals using the old bitmap code provide anything that is worth the amount of code that is dragged in to support them. So I disable them when building for myself and would continue to do so.
But I am open to being convinced. Can you summarize what the block terminal offers that isn't provided by the dumb or sixelgd terminals?