Ethan Merritt

'set contourfill defined' causes an error with another keyword

The first one is a misleading error message ('defined' and 'firstlinetype' are mutually exclusive options). The second one is a bug. Fixed in 6.1, pending for 6.0

Memory leaks if commands fail

`local array` at top-level crashes gnuplot silently

Confirmed. It broke between 6.0.1 and 6.0.2 . The breakage was imported from 6.1 so the fix is needed there also. Fix pushed for both branch-6-0-stable and master

I am puzzled. Your minimal reproducer is a real bug (trying to plot from an empty data block). I pushed a fix to both 6.0 and 6.1 But that pattern does not occur in mask_pm3d.dem. I cannot reproduce failure with that demo either before or after the fix. Edit: OK, I see that the problem could occur with that demo if the loadpath, or GNUPLOT_LIB, is set incorrectly. Then it would try to create a data block from a file not in the search path, resulting in an empty data block.

I am puzzled. Your minimal reproducer is a real bug (trying to plot from an empty data block). I pushed a fix to both 6.0 and 6.1 But that pattern does not occur in mask_pm3d.dem. I cannot reproduce failure with that demo either before or after the fix.

Looks good. The only other thing I see is that when you add a file to the package, it needs to be listed in .../src/Makefile.am gnuplot_SOURCES so that the automake system tracks it and includes it in the source package from "make dist". diff --git a/src/Makefile.am b/src/Makefile.am index 8e0685733..132111689 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -56,7 +56,7 @@ help.c help.h hidden3d.c hidden3d.h history.c internal.c internal.h \ interpol.c interpol.h jitter.c jitter.h libcerf.c...