Re: [Gnubiff-devel] Problem compiling cvs version, gcc 3.4.1

[Robert S. <sow...@gm...>]

Hi,

> The CVS version doesn't compile (see log at the end). While looking at 
I fixed it, should be available in CVS now (there was a guint casting
instead of a guint & casting). My compiler didn't complain (no error, no
warning), so I didn't notice the typo. Does it compile now without problems?

> the code, I saw that some function prototypes were declared without 
> argument names (biff.h, load_para/save_para).
> 
> I would prefer we keep them everywhere since it allows to get a quick 
> idea on what the function is doing.
Okay.

Another problem I noticed in "ui-popup.cc": The code for function
"Popup::show()" begins with
	// FIXME ?
	//	for (unsigned int i=0; i<biff_->size(); i++)
	//		biff_->applet(i)->stop();
So in some earlier version we stopped updating while showing the popup.
Currently we update while showing the popup. When the update is finished,
the old data is freed. If such a header is selected in the popup gnubiff
segfaults.
I can fix this. Before there should be a decision in what order mail headers
are to be displayed (see Calum's mail), so I have to change the code only
once.

Yet another issue: When looking at the screenshot at the gnubiff homepage I
notice that in the popup only "Nicolas Rougier" appears not "Nicolas Rougier
<Nic...@lo...>". Is this a feature that I missed (or worse: a
feature that I broke)?

CU Robert :-)

-- 
Sparen beginnt mit GMX DSL: http://www.gmx.net/de/go/dsl