[GExperts-CVS] gexperts/unstable/Src/OpenFile GX_OpenFile.dfm,1.2,1.3 GX_OpenFile.pas,1.3,1.4 GX_OpenFileConfig.pas,1.3,1.4

[Erik B. <eb...@us...>]

Update of /cvsroot/gexperts/gexperts/unstable/Src/OpenFile
In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv24186/OpenFile

Modified Files:
	GX_OpenFile.dfm GX_OpenFile.pas GX_OpenFileConfig.pas 
Log Message:
TODO item cleanup

Index: GX_OpenFileConfig.pas
===================================================================
RCS file: /cvsroot/gexperts/gexperts/unstable/Src/OpenFile/GX_OpenFileConfig.pas,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- GX_OpenFileConfig.pas	10 Apr 2005 21:13:32 -0000	1.3
+++ GX_OpenFileConfig.pas	10 Apr 2005 21:21:21 -0000	1.4
@@ -7,8 +7,7 @@
   StdCtrls, Buttons, ComCtrls, ExtCtrls, SpinIntEdit;
 
 type
-  {$MESSAGE WARN 'Remove class'}
-  TIDEOverride = class(TStringList)
+  //TODO 3 -cCleanup -oAnyone: Move configuration main storage to a single place in the expert class  TIDEOverride = class(TStringList)
   private
     function GetOverrideOpenUnit: Boolean;
     procedure SetOverrideOpenUnit(Value: Boolean);
@@ -340,8 +339,7 @@
   KeyString: string;
 begin
   // Do not localize any of the following lines
-  {$MESSAGE WARN 'Don''t .Create here?'}
-  FileTypes := TFileTypes.Create(TFileType);
+  //TODO 3 -cCleanup -oAnyone: Don't .Create here, to discourage leaks  FileTypes := TFileTypes.Create(TFileType);
   IDEOverride := TIDEOverride.Create;
   Settings := TGExpertsSettings.Create(ConfigInfo.GExpertsIdeRootRegistryKey);
   try

Index: GX_OpenFile.dfm
===================================================================
RCS file: /cvsroot/gexperts/gexperts/unstable/Src/OpenFile/GX_OpenFile.dfm,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -d -r1.2 -r1.3
--- GX_OpenFile.dfm	10 Apr 2005 21:13:32 -0000	1.2
+++ GX_OpenFile.dfm	10 Apr 2005 21:21:21 -0000	1.3
@@ -53,9 +53,9 @@
         OnShow = tabSearchPathShow
         object pnlSearchPathFooter: TPanel
           Left = 0
-          Top = 282
+          Top = 283
           Width = 543
-          Height = 34
+          Height = 33
           Align = alBottom
           BevelOuter = bvNone
           TabOrder = 1
@@ -73,7 +73,7 @@
           Left = 0
           Top = 0
           Width = 543
-          Height = 282
+          Height = 283
           Align = alClient
           BevelOuter = bvNone
           BorderWidth = 3
@@ -83,7 +83,7 @@
             Left = 3
             Top = 3
             Width = 537
-            Height = 276
+            Height = 277
             Align = alClient
             Columns = <
               item
@@ -117,7 +117,7 @@
           Left = 0
           Top = 0
           Width = 543
-          Height = 282
+          Height = 283
           Align = alClient
           BevelOuter = bvNone
           BorderWidth = 3
@@ -127,7 +127,7 @@
             Left = 3
             Top = 3
             Width = 537
-            Height = 276
+            Height = 277
             Align = alClient
             Columns = <>
             DragMode = dmAutomatic
@@ -142,9 +142,9 @@
         end
         object pnlProjFooter: TPanel
           Left = 0
-          Top = 282
+          Top = 283
           Width = 543
-          Height = 34
+          Height = 33
           Align = alBottom
           BevelOuter = bvNone
           TabOrder = 1
@@ -167,7 +167,7 @@
           Left = 0
           Top = 0
           Width = 543
-          Height = 282
+          Height = 283
           Align = alClient
           BevelOuter = bvNone
           BorderWidth = 3
@@ -177,7 +177,7 @@
             Left = 3
             Top = 3
             Width = 537
-            Height = 276
+            Height = 277
             Align = alClient
             Columns = <>
             DragMode = dmAutomatic
@@ -192,9 +192,9 @@
         end
         object pnlCommonFooter: TPanel
           Left = 0
-          Top = 282
+          Top = 283
           Width = 543
-          Height = 34
+          Height = 33
           Align = alBottom
           BevelOuter = bvNone
           TabOrder = 1
@@ -217,7 +217,7 @@
           Left = 0
           Top = 0
           Width = 543
-          Height = 282
+          Height = 283
           Align = alClient
           BevelOuter = bvNone
           BorderWidth = 3
@@ -227,7 +227,7 @@
             Left = 3
             Top = 3
             Width = 537
-            Height = 276
+            Height = 277
             Align = alClient
             Columns = <>
             DragMode = dmAutomatic
@@ -242,9 +242,9 @@
         end
         object pnlFavFooter: TPanel
           Left = 0
-          Top = 282
+          Top = 283
           Width = 543
-          Height = 34
+          Height = 33
           Align = alBottom
           BevelOuter = bvNone
           TabOrder = 1
@@ -274,9 +274,9 @@
         OnShow = tabRecentShow
         object pnlRecentFooter: TPanel
           Left = 0
-          Top = 282
+          Top = 283
           Width = 543
-          Height = 34
+          Height = 33
           Align = alBottom
           BevelOuter = bvNone
           TabOrder = 1
@@ -303,7 +303,7 @@
           Left = 0
           Top = 0
           Width = 543
-          Height = 282
+          Height = 283
           Align = alClient
           BevelOuter = bvNone
           BorderWidth = 3
@@ -312,7 +312,7 @@
             Left = 3
             Top = 3
             Width = 537
-            Height = 276
+            Height = 277
             Align = alClient
             Columns = <>
             DragMode = dmAutomatic

Index: GX_OpenFile.pas
===================================================================
RCS file: /cvsroot/gexperts/gexperts/unstable/Src/OpenFile/GX_OpenFile.pas,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- GX_OpenFile.pas	10 Apr 2005 21:13:32 -0000	1.3
+++ GX_OpenFile.pas	10 Apr 2005 21:21:21 -0000	1.4
@@ -630,7 +630,7 @@
   SearchRec: TSearchRec;
   FileSpec: string;
 begin
-  {$MESSAGE WARN 'Make this threaded'}
+  //TODO 2 -cFeature -oAnyone: Make this threaded
   FileSpec := GetIdeRootDirectory + AddSlash('lib') + '*.dcu';
   Found := SysUtils.FindFirst(FileSpec, faAnyFile, SearchRec);
   try
@@ -932,7 +932,7 @@
 var
   Finder: TFileFindThread;
 begin
-  {$MESSAGE WARN 'Make this threaded without using WaitFor'}
+  //TODO 2 -cBug -oAnyone: Make this threaded without using WaitFor
   Finder := TFileFindThread.Create;
   try
     Finder.RecursiveSearchDirs.Add(ExtractFilePath(GetIdeRootDirectory) + AddSlash('Source'));
@@ -980,7 +980,7 @@
 
 procedure TfmOpenFile.tbnHelpClick(Sender: TObject);
 begin
-  ShowMessage('No help yet...');
+  // TODO 2 -cBug -oAnyone: Help has to be integrated
 end;
 
 function TfmOpenFile.MakeFileName(Item: TListItem): string;