#577 GX_CondDefine.inc: the Delphi 11 workarounds are also active in Delphi 12 and 13

[Thomas Mueller]

Source/Include/GX_CondDefine.inc line 280 excludes three workarounds from Delphi 12 and later with {$IFNDEF GX_DELPHI_12_UP}, under the comment "we hope this gets fixed in Delphi 12 and later". The define is called GX_DELPHI12_UP, and nothing defines the misspelt name, so the {$IFNDEF} never excludes anything.

A compile with the switches of the RS13 build confirms that these are defined there:

• GX_AV_IN_CODE_FORMATTER_FIX_ENABLED (GX_CodeFormatterFormatter.pas, the workaround for bug [#314])
• GX_ACTION_BROKER_IMAGELIST_FIX_ENABLED (GX_ActionBroker.pas)
• GX_WRONG_BUTTON_PARENTS_IN_PATH_EDIT_FIX_ENABLED (GX_IdeSearchPathEnhancer.pas)

Correcting the spelling turns all three off in Delphi 12 and 13. Whether these IDEs still need them has not been tested, so that has to be checked for each of the three first.

[Thomas Mueller]

Fixed in [r6062].

Correcting only the spelling would have switched off more than intended, so the three workarounds were looked at one by one:

• GX_WRONG_BUTTON_PARENTS_IN_PATH_EDIT_FIX_ENABLED: tested in Delphi 12 and 13 with it switched off. In the Directories dialog of the Library path, the Tasks and Replace buttons sit on the same panel as Add and Delete, at the same height, so the workaround only put them where they already were. It is now limited to Delphi 11.
• GX_ACTION_BROKER_IMAGELIST_FIX_ENABLED: its own comment says it works around a bug in Delphi 12's INTAServices.AddMasked, and it was added two months after Delphi 12 came out. It stays active from Delphi 11 on.
• GX_AV_IN_CODE_FORMATTER_FIX_ENABLED: the formatter unit without optimization, for [#314], which was never reproduced. Whether later compilers still need it cannot be tested, so it also stays active from Delphi 11 on.

So nothing changes for users.