Not sure how close to the target I hit with those changes, but was able to compile. .inc file change is not made, because could not remember the version etc on top of my head.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Since [r5996] GExperts no longer uses IOTACodeFormatter or IOTACodeFormatterServices370 from the ToolsAPI. It has its own copies of the two interfaces (IGxOtaCodeFormatter, IGxOtaCodeFormatterServices370) and asks the IDE at run time whether it supports them. So it should compile with 13.0, 13.1 and 13.2 without a GX_DELPHI13_2_UP define, and the reporter of [#555] confirmed that it compiles and runs in Delphi 13 CE.
Such a define could be set with {$IF declared(RTLVersion132)}, but it would bring the problem of #555 back: a DLL compiled with 13.2 that uses the ToolsAPI's declarations imports them from designide370.bpl, and 13.0 and 13.1 then refuse to load it. With the copies, one DLL works in all three updates and offers the formatter wherever the IDE supports it.
Your patch is against r6016, which already contains that change. Did you get a compiler error without the patch? If so, please post the message, the file and the line, and which Delphi 13 update you compiled with.
Not sure how close to the target I hit with those changes, but was able to compile. .inc file change is not made, because could not remember the version etc on top of my head.
Since [r5996] GExperts no longer uses
IOTACodeFormatterorIOTACodeFormatterServices370from the ToolsAPI. It has its own copies of the two interfaces (IGxOtaCodeFormatter,IGxOtaCodeFormatterServices370) and asks the IDE at run time whether it supports them. So it should compile with 13.0, 13.1 and 13.2 without aGX_DELPHI13_2_UPdefine, and the reporter of [#555] confirmed that it compiles and runs in Delphi 13 CE.Such a define could be set with
{$IF declared(RTLVersion132)}, but it would bring the problem of #555 back: a DLL compiled with 13.2 that uses the ToolsAPI's declarations imports them from designide370.bpl, and 13.0 and 13.1 then refuse to load it. With the copies, one DLL works in all three updates and offers the formatter wherever the IDE supports it.Your patch is against r6016, which already contains that change. Did you get a compiler error without the patch? If so, please post the message, the file and the line, and which Delphi 13 update you compiled with.
Related
Bugs:
#555Commit: [r5996]
Yes,
Now it copiles out of box, nice, sorry it took ages to try...
-tee-