Garnet - a Graphical Toolkit for Lisp / Bugs / #24 Simplify VERIFY-DISPLAY-CAN-BE-OPENED

#24 Simplify VERIFY-DISPLAY-CAN-BE-OPENED

Milestone: demos

Status: open

Owner: nobody

Labels: None

Priority: 5

Updated: 2015-07-30

Created: 2015-07-30

Creator: Robert P. Goldman

Private: No

This function reads the DISPLAY variable, parses it, and then checks to see if it can be opened.

AFAICT this is unnecessarily complicated. Since we always try to open the display corresponding to the value of DISPLAY, we might as well just use XLIB:OPEN-DEFAULT-DISPLAY. Otherwise we are wasting work by duplicating what XLIB:OPEN-DEFAULT-DISPLAY does (better) to parse the value of DISPLAY

If you (Fred) don't object, I'll kill the body of VERIFY-DISPLAY-CAN-BE-OPENED and use XLIB:OPEN-DEFAULT-DISPLAY to do the heavy-lifting instead.

Discussion

Description has changed:

Diff:

--- old
+++ new
@@ -2,4 +2,4 @@

 AFAICT this is unnecessarily complicated.  Since we always try to open the display corresponding to the value of `DISPLAY`, we might as well just use `XLIB:OPEN-DEFAULT-DISPLAY`. Otherwise we are wasting work by duplicating what `XLIB:OPEN-DEFAULT-DISPLAY` does (better) to parse the value of `DISPLAY`

-If you (Fred) don't object, I'll kill the body of `VERIFY-DISPLAY-CAN-BE-OPENED` and use 
+If you (Fred) don't object, I'll kill the body of `VERIFY-DISPLAY-CAN-BE-OPENED` and use `XLIB:OPEN-DEFAULT-DISPLAY` to do the heavy-lifting instead.

Simplify VERIFY-DISPLAY-CAN-BE-OPENED

Garnet Common Lisp GUI Library

Group

Searches

Help

#24 Simplify VERIFY-DISPLAY-CAN-BE-OPENED

Discussion