[Ganglia-svn] SF.net SVN: ganglia:[2008] trunk/monitor-core/libmetrics/solaris/metrics.c

[<d_p...@us...>]

Revision: 2008
          http://ganglia.svn.sourceforge.net/ganglia/?rev=2008&view=rev
Author:   d_pocock
Date:     2009-07-30 15:12:38 +0000 (Thu, 30 Jul 2009)

Log Message:
-----------
Bug 237: revise comments in code relating to fix

Modified Paths:
--------------
    trunk/monitor-core/libmetrics/solaris/metrics.c

Modified: trunk/monitor-core/libmetrics/solaris/metrics.c
===================================================================
--- trunk/monitor-core/libmetrics/solaris/metrics.c	2009-07-30 10:19:39 UTC (rev 2007)
+++ trunk/monitor-core/libmetrics/solaris/metrics.c	2009-07-30 15:12:38 UTC (rev 2008)
@@ -202,10 +202,12 @@
    debug_msg("%s: Just did kstat_lookup().",name);
 
    /*
-    * CPU_INFO module & instance check: Michael Hom <mic...@ya...>
-    * If the first online CPU is not in slot #0, gmond will segfault and core dump.
-    * If "km_name = NULL" and "km_instance = -1", then first instance of the module is returned.
-    *     ks = kstat_lookup(kc, km_name, -1, NULL);
+    * A hack contributed by Michael Hom <mic...@ya...>
+    * cpu_info0 doesn't always exist on Solaris, as the first CPU
+    * need not be in slot 0.
+    * Therefore, if ks == NULL after kstat_lookup(), we try
+    * to find the first valid instance using the query:
+    *   ks = kstat_lookup(kc, km_name, -1, NULL);
     */
 
    if ((strcmp(km_name, "cpu_info") == 0) && (ks == NULL))  {


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.