[Ganglia-svn] SF.net SVN: ganglia: [1473] trunk/monitor-core/libmetrics/linux/metrics.c

[<ca...@us...>]

Revision: 1473
          http://ganglia.svn.sourceforge.net/ganglia/?rev=1473&view=rev
Author:   carenas
Date:     2008-06-29 18:33:39 -0700 (Sun, 29 Jun 2008)

Log Message:
-----------
libmetrics: linux: update_ifdata cleanup

use strtoul for consistency, add some comments and read returned valued to
avoid the following warning :

  metrics.c:242: warning: ignoring return value of 'strtol', declared with attribute warn_unused_result

Modified Paths:
--------------
    trunk/monitor-core/libmetrics/linux/metrics.c

Modified: trunk/monitor-core/libmetrics/linux/metrics.c
===================================================================
--- trunk/monitor-core/libmetrics/linux/metrics.c	2008-06-29 21:05:07 UTC (rev 1472)
+++ trunk/monitor-core/libmetrics/linux/metrics.c	2008-06-30 01:33:39 UTC (rev 1473)
@@ -221,6 +221,7 @@
 		     net_dev_stats *ns = hash_lookup(src, n); 
 		     if ( !ns ) return;
 
+		     /* receive */
 		     rbi = strtoul( p, &p ,10);
 		     if ( rbi >= ns->rbi ) {
 			l_bytes_in += rbi - ns->rbi;
@@ -238,8 +239,11 @@
 			l_pkts_in += ULONG_MAX - ns->rpi + rpi;
 		     }
 		     ns->rpi = rpi;
+		     
+		     /* skip unneeded metrics */
+		     for (i = 0; i < 6; i++) rbo = strtoul(p, &p, 10);
 
-		     for (i = 0; i < 6; i++) strtol(p, &p, 10);
+		     /* transmit */
 		     rbo = strtoul( p, &p ,10);
 		     if ( rbo >= ns->rbo ) {
 			l_bytes_out += rbo - ns->rbo;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.