From: Carlo M. A. B. <ca...@sa...> - 2008-03-29 08:27:21
|
On Fri, Mar 28, 2008 at 11:44:44PM -0600, Brad Nicholes wrote: > > The problem is the typedef of g_val_t. Both libmetrics and the metric modules need this typedef. Before the commits, the metric modules had to include libmetrics.h to get this typedef. This would have required libmetrics.h to become one of the public headers. So rather than make libmetrics.h a public header, I pulled the typedef into gm_metrics.h. g_val_t is a public interface of libganglia and libganglia is used by the modules so it should be IMHO moved into "ganglia.h" or whathever the public interface for libganglia is. Carlo |