Menu

#365 jabber:iq:time/display non UTF8

critical
closed-invalid
jabberoo (27)
5
2002-03-24
2002-03-24
No

Quoting from jabberoo-session.cc:
strftime(timestr, 1024, "%c", loctime);
string localUTF8Time = string(timestr);

Why place "UTF8" in the variable name when the value is
locale-dependent and is not converted from the current
locale to UTF8? This makes Gabber cough on bad UTF8 and
die when serving user information.

Discussion

  • Julian Missig

    Julian Missig - 2002-03-24

    Logged In: YES
    user_id=9539

    Except that you're not understanding what's going on in that
    code. Right after the code you quote, there's:
    evtOnTime(localUTF8Time, UTF8TimeZone);

    This is something which was added to CVS and wasn't in 0.8.7
    (which is why you experienced crashes). If you look in
    Gabber, it catches evtOnTime and converts the strings to UTF-8.

     
  • Julian Missig

    Julian Missig - 2002-03-24
    • assigned_to: nobody --> julian
    • status: open --> closed-invalid
     

Log in to post a comment.