[fuse-emulator-devel] [ fuse-emulator-Patches-3575831 ] Obsolete autoconf macros

[SourceForge.net <no...@so...>]

Patches item #3575831, was opened at 2012-10-09 14:28
Message generated for change (Comment added) made by fredm
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3575831&group_id=91293

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: Sergio Baldoví (sbaldovi)
Assigned to: Nobody/Anonymous (nobody)
Summary: Obsolete autoconf macros

Initial Comment:
This patch replace some autoconf macros that are obsolete:
AC_INLINE -> AC_C_INLINE
AC_HELP_STRING -> AS_HELP_STRING
AC_WARN ->  AC_MSG_WARN
AC_LINK_FILES -> AC_CONFIG_LINKS
AC_TRY_COMPILE -> AC_COMPILE_IFELSE

There are still some obsolete macros in the source as they will need further testing (i.e., AC_CANONICAL_SYSTEM and AC_PROG_LIBTOOL)

http://www.gnu.org/software/autoconf/manual/autoconf-2.67/html_node/Obsolete-Macros.html

----------------------------------------------------------------------

>Comment By: Fredrick Meunier (fredm)
Date: 2012-10-15 04:45

Message:
> I think the contents of the m4 directory should be distributed with the
tarball?

Maybe not as it is all packaged into aclocal.m4

----------------------------------------------------------------------

Comment By: Fredrick Meunier (fredm)
Date: 2012-10-15 04:26

Message:
Thanks, all committed by revision 4749.

I think the contents of the m4 directory should be distributed with the
tarball?

----------------------------------------------------------------------

Comment By: Sergio Baldoví (sbaldovi)
Date: 2012-10-14 14:55

Message:
Again, a few more patches:
- Replace obsolete macros: AC_CANONICAL_SYSTEM ([1],[2]) and
AC_PROG_LIBTOOL ([3])
- Split acinclude.m4 in files in a m4/ directory ([4]); acinclude.m4 has
been removed.

Moreover, ui/win32/installer/Makefile.am file is no longer needed and
should be removed.

[1]http://www.gnu.org/software/automake/manual/autoconf.html#Canonicalizing
[2]http://www.gnu.org/software/automake/manual/automake.html#Cross_002dCompilation
[3]http://www.gnu.org/software/libtool/manual/html_node/LT_005fINIT.html#LT_005fINIT
[4]http://www.gnu.org/software/automake/manual/automake.html#Local-Macros

----------------------------------------------------------------------

Comment By: Fredrick Meunier (fredm)
Date: 2012-10-11 03:06

Message:
Thanks, all committed by revision 4745.

I agree that having separate files in an m4 directory would be better than
having the one long file.

----------------------------------------------------------------------

Comment By: Sergio Baldoví (sbaldovi)
Date: 2012-10-10 15:50

Message:
A few more patches...
- Don't use AC_OUTPUT with parameters
- Remove unused GLIB 1.x and GTK 1.x macros from acinclude.m4. 

There is a trend to use m4/ as a directory for macro files instead using
acinclude.m4, because it often leads to overly long files with no logic
distinction between macros. We currently use macros for glib2, libxml2,
gtk2, sdl and pkg-config. Any views?

----------------------------------------------------------------------

Comment By: Fredrick Meunier (fredm)
Date: 2012-10-10 05:59

Message:
Thanks, committed in revision 4741.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=596650&aid=3575831&group_id=91293