Menu

#370 z80 test suite test "39" tests opcode 29

v1.3.4
closed-fixed
z80 (1)
5
2017-03-11
2017-03-03
No

Gareth Adams reports:

"I’ve noticed that, in tests.in the test for opcode 39 (ADD HL, SP) is:

39
0000 0000 0000 1aef 0000 0000 0000 0000 0000 0000 c534 0000 0000
00 00 0 0 0 0 1
0000 29 -1
-1

But that executes opcode 29.

The tests.expected also has 29 in the expected call sequence and I’m not convinced that the result of the addition is correct?"

This test should be corrected to actually test ADD HL, SP rather than 0x29 ADD HL, HL as we already have a perfectly good test for that.

Discussion

  • Philip Kendall

    Philip Kendall - 2017-03-03

    Fixed in commit 76c7220.

     
  • Philip Kendall

    Philip Kendall - 2017-03-03
    • status: open --> pending-fixed
     
  • Fredrick Meunier

    • status: pending-fixed --> closed-fixed
     

Log in to post a comment.