#44 Please document separator priorities

[Nirgal Vourgère]

Hi

The +_- separators priorities, if any, need to be documented.

For example, running "duply ... cleanup+backup+purge --force", I got:

--- Start running command CLEANUP at 00:35:35.103 ---
BackendException: ssh connection.... [Errno 110] Connection timed out
00:37:37.164 Task 'CLEANUP' failed with exit code '23'.
--- Finished state FAILED 'code 23' at 00:37:37.164 - Runtime 00:02:02.060 ---
--- Skipping command PRE ! ---
--- Start running command BKP at 00:37:37.177 ---
...

It is a bit weird for me that when running cleanup+backup+purge a failure in cleanup would result in "pre" being skiped, but "bkp" being run.

Please improve the documentation:
Looks like cleanup+backup+purge means (cleanup+pre)bkp(post+purge) or (((cleanup+pre)_bkp)_post)+purge) or something similar.

If you intended to support operator priorities, it would make sense to have backup translate into (pre_bkp_post) with these parenthesis. I mean it woud be nice to have cleanup+backup+purge translate into cleanup+(pre_bkp_post)+purge.

Thank you for duply!

[ede]

On 11.09.2018 12:07, Nirgal Vourgère wrote:

---

[feature-requests:#44] https://sourceforge.net/p/ftplicity/feature-requests/44/ Please document separator priorities

Status: open
Group: Next Release (example)
Created: Tue Sep 11, 2018 10:07 AM UTC by Nirgal Vourgère
Last Updated: Tue Sep 11, 2018 10:07 AM UTC
Owner: nobody

Hi

The +_- separators priorities, if any, need to be documented.

For example, running "duply ... cleanup+backup+purge --force", I got:

--- Start running command CLEANUP at 00:35:35.103 ---
BackendException: ssh connection.... [Errno 110] Connection timed out
00:37:37.164 Task 'CLEANUP' failed with exit code '23'.
--- Finished state FAILED 'code 23' at 00:37:37.164 - Runtime 00:02:02.060 ---
--- Skipping command PRE ! ---
--- Start running command BKP at 00:37:37.177 ---
...

It is a bit weird for me that when running cleanup+backup+purge a failure in cleanup would result in "pre" being skiped, but "bkp" being run.

Please improve the documentation:
Looks like cleanup+backup+purge means (cleanup+pre)/bkp/(post+purge) or (((cleanup+pre)_bkp)_post)+purge) or something similar.

If you intended to support operator priorities, it would make sense to have backup translate into (pre_bkp_post) with these parenthesis. I mean it woud be nice to have cleanup+backup+purge translate into cleanup+(pre_bkp_post)+purge.

hmm.. you stumbled over a bug there. you are right that currently

cleanup+backup+purge

translates to

cleanup+pre_bkp_post+purge

instead of

cleanup+(pre_bkp_post)+purge

.

that is an oversight and unfortunately not that easy to fix (no prioritizing, grouping implemented currently). will have a look at it though when time permits.

in the meantime you could work around it by not using the macro and reordering the commands like

pre_cleanup+bkp+purge_post

also

duply profile cleanup && duply profile backup && duply profile purge

will probably work.

be aware that the conditionals are mainly for the pre/post scripts as duplicity tends to return error codes often eg. if it cannot access files (even some not meant to be in the backup) or when some warnings occured.

Thank you for duply!

your welcome.. nice catch! ..ede/duply.net

[ede]

hey Nirgal,

would you mind testing if
  http://duply.net/wiki/index.php/Duply-code#Latest_Development_Snapshot
works as you'd expect?

cleanup+backup+purge translates now to cleanup+[pre_bkp_post]+purge so the command should be skipped as expected.

thanks ..ede/duply.net

[ede]

released in duply 2.2.. ede/duply.net

[Nirgal Vourgère]

Sorry I haven't been able to test that yet, I'm lazilly using Debian stable packages.
However, this is exactly what should have been done. This looks perfect!
Thank you very much. :)