Ampersand '&' in target URL causes duplicity to fork into background
Brought to you by:
edso
Menu
▾
▴
#84 Ampersand '&' in target URL causes duplicity to fork into background
In an enhancement I am working on for duplicity to enable it to use the 'multi' backend more effectively, I have put the '&' in the URL to provide additional parameters via query string... however '&' is causing duplicity to fork in the background when executed.
I would think that all parameters would be properly wrapped in quotes for execution to avoid shell interpretation.
it should properly quote the url.
please send me a full terminal output of your command run w/ the '--preview' option.
..ede
PS: wrt. your other tickets.. pls give me some time to find time.
Command line output:
$ duply multi-ionic status --preview
Start duply v1.5.6.1, time is 2015-07-16 11:43:55.
Using profile '/home/harningt/.duply/multi-ionic'.
Using installed duplicity version 0.7.03, python 2.7.9, gpg 1.4.18 (Home:
~/.gnupg), awk 'GNU Awk 4.1.2, API: 1.1', bash '4.3.33(1)-release
(x86_64-alpine-linux-musl)'.
Using configured key 'F20DDADB' as signing key.
Test - En/Decryption skipped. (Testing disabled)
--- Start running command STATUS at 11:43:56.000 ---
TMPDIR='/tmp' SIGN_PASSPHRASE='REMOVED' FTP_PASSWORD= duplicity
collection-status --name 'duply_multi-ionic' --encrypt-key 62F49ED5
--sign-key F20DDADB --verbosity '4' --exclude-other-filesystems
--asynchronous-upload --exclude-if-present '.duplicity-ignore'
--full-if-older-than 1M --volsize 50
multi:///home/harningt/.duply/multi-ionic/config.json?mode=mirror&onfail=abort
--- Finished state OK at 11:43:56.000 - Runtime 00:00:00.000 ---
I see some items quoted and others not quoted...
~~ EDIT - dropped email junk~~
Last edit: Thomas Harning Jr. 2015-07-16
On 16.07.2015 18:18, Thomas Harning Jr. wrote:
is outdated. you filed bugs against 1.9.2 , so why are you not using it ;)?
.e.de
Multiple machines and legacy patched duply versions (at the time to
workaround GPG password prompting issues) are to blame there.
Start duply-new v1.9.2, time is 2015-07-20 16:04:24.
Using profile '/home/harningt/.duply/multi-ionic'.
Using installed duplicity version 0.7.03, python 2.7.9, gpg 1.4.18
(Home: ~/.gnupg), awk 'GNU Awk 4.1.2, API: 1.1', grep 'grep:
unrecognized option: version', bash '4.3.33(1)-release
(x86_64-alpine-linux-musl)'.
Cannot use gpg-agent. GPG_AGENT_INFO not set.
-- Run cmd -- Checking TEMP_DIR '/tmp' is a folder --
test -d /tmp 2>&1
-- Run cmd -- Checking TEMP_DIR '/tmp' is writable --
test -w /tmp 2>&1
Test - En/Decryption skipped. (Testing disabled)
--- Start running command STATUS at 16:04:25.000 ---
TMPDIR='/tmp' SIGN_PASSPHRASE='REMOVED' FTP_PASSWORD= duplicity
collection-status --name duply_multi-ionic --encrypt-key 62F49ED5
--sign-key F20DDADB --verbosity '4' --exclude-other-filesystems
--asynchronous-upload --exclude-if-present '.duplicity-ignore'
--full-if-older-than 1M --volsize 50
'multi:///home/harningt/.duply/multi-ionic/config.json?mode=mirror&onfail=abort'
--- Finished state OK at 16:04:25.000 - Runtime 00:00:00.000 ---
The 'grep: unrecognized version' detail is because the version present
is the one patched to parse both stdin/stderr for grep options... and
use 'env -u GREP_OPTIONS grep "$@"' instead of 'grep --color=never
"$@"'
On 16.07.2015 18:18, Thomas Harning Jr. wrote:
is outdated. you filed bugs against 1.9.2 , so why are you not using it ;)?
.e.de
It looks like it is coming from the 'duplify' command where everything before '--' in the command setup is setup to be auto-quoted, but everything after is not.
It seems anything set in DUPL_OPTS from the config script are not quoted (probably safe, but may need notes) and the TARGET... and SOURCE for some call-outs..
this fixed in at least duply 1.9.x . tests were done with acient 1.5.6.x version.
..ede