Menu

#136 Support priority icons when importing from MindManager

closed-accepted
5
2011-03-31
2011-03-30
No

I tried the patch I found here for mindmanager2mm to support priority icons. It failed, causing a stack dump due to syntactically incorrect xslt. The match was attempting to locate all Task elements with TaskPriority attribute containing a wildcard string, which is not supported (and besides which, was missing some final punctuation). All we really need is to find all the Task elements containing TaskPriority attributes, e.g.

<ap:Task TaskPriority="urn:mindjet:Prio2" Dirty="0000000000000001" Resources="BG" ResourcesLoad="100" TaskPriorityReadOnly="false" DurationReadOnly="false" StartDateReadOnly="false" DeadlineDateReadOnly="false" TaskPercentageReadOnly="false" ResourcesReadOnly="false"/>

The <xsl:choose> takes care of the rest, narrowing it down to up to 5 priority levels (verified that MindManager 9 supports this).

The attached updated patch fixes the issue. I tested this with a MindManager 9 mmap file and it imports fine with Freemind 0.9.0.

Discussion

  • Ben Armstrong

    Ben Armstrong - 2011-03-30

    Updated priority icon patch

     
  • Ben Armstrong

    Ben Armstrong - 2011-03-30

    By the way, I am referring to artifact #1892463. I would have updated that patch, except I did not understand how to do it.

     
  • Ben Armstrong

    Ben Armstrong - 2011-03-30

    By the way, upon reviewing my patch, I realized that this would lead to the creation of empty <icon /> elements if none of the choices match. Unless it can be shown that some version of MindManager produces such output, this shouldn't be a problem. However, to be on the safe side, I hand-edited the .mm to include an empty <icon /> to see what would happen. The result is cosmetically imperfect, but does not prevent the .mm from loading, and can be manually corrected by removing the icon from that node.

     
  • Christian Foltin

    • status: open --> closed-accepted
     
  • Christian Foltin

    Dear contributor,

    thanks for your patch that has been integrated into the version control. You can verify that this is correct by considering
    http://freemind.git.sourceforge.net/git/gitweb.cgi?p=freemind/freemind;a=summary

    Best regards,

    Chris from the FreeMind team

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.