This is a good idea. The code is a little odd in places --- not sure why you dropped the null test for the unit, and the check if a colony owner is European is redundant, but I will merge this (plus edits) soon.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Looking at this again it is still a good idea, but implementing it as a special case in the client is the wrong way to do it. All the existing restrictions on colony building are centralized in the Player.canClaim...(Tile) routines. That is where the guts of this patch should be directed.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I based this suggestion: https://sourceforge.net/p/freecol/improvement-requests/184/
This is a good idea. The code is a little odd in places --- not sure why you dropped the null test for the unit, and the check if a colony owner is European is redundant, but I will merge this (plus edits) soon.
not sure why you dropped the null test for the unit
The NetBeans said that this check is unnecessary. I confined it and then removed.
Looking at this again it is still a good idea, but implementing it as a special case in the client is the wrong way to do it. All the existing restrictions on colony building are centralized in the Player.canClaim...(Tile) routines. That is where the guts of this patch should be directed.
Closing. The codebase has moved on, and while the idea is good, the implementation is fatally flawed.