#254 custom hill or mountain tiles

[artoo]

I tried to add a tropicalHighlands tile, so far so good, all fine, it griows the coffee.
However, the mapgen will not generate custom hills or mountains, since the code is fixed to these two.

My question would be, what is the best approach to solve this? Patching source?
The need for a custom tile comes from coffee being highland grown, no temperatures below 20 and high humidity.
If I add coffee to the normal hills, it would grow in pretty cold regions, since hills can't be limited to a terrain.

[Stian Grenborgen]

I have just improved the map generator so that different types of hills/mountains can be defined (for example by having different latitudes).

• Terrain that permits an altitude of 15 is counted as hills.
• Terrain that permits an altitude of 25 is counted as mountains.

[artoo]

Nice, but one unintended side effect, generted tropicalHighland tiles have rivers, is-elevation is true.

[Stian Grenborgen]

Are you saying that you want rivers to be generated on top of the rivers? ...or was there something wrong?

[artoo]

Yes, something slight wrong, the generated custom hills tiles have rivers generated in the tile.
If this is supposed to work like normal hills/mountains, no river should be generated on the "is-elevation" tiles?

see here... a tropical highland tile with river is visible right above the cocoa tile info.
https://sourceforge.net/p/freecol/discussion/141200/thread/db977f4a49/ecd7/372c/0a86/3288/attachment/th_tile.png/thumb

https://sourceforge.net/p/freecol/discussion/141200/thread/db977f4a49/ecd7/372c/0a86/3288/attachment/th_tile.png

[artoo]

Reminds me, would you mind accepting the GH PR? Small change but big difference.
I checked with and without mod, the train panel looks fine with default freecol rules.
https://github.com/FreeCol/freecol/pull/131