Hi,
I just downloaded the nightly release for the first time, and started playing. I noticed that the production numbers now have "0+" in front of them. Is this a bug? It appears in a lot of the screenshots of bug reports, so I was wondering if it was a new feature.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi,
I looked for why it is displayed like this.
I found that it is a change related to [https://github.com/FreeCol/freecol/search?q=9a1bbddf79e1cbcf28d8a118bad96a1449a9667e&type=commits]: "Zero stock number is valid in ProductionLabel."
Comment of the commit seems to not match with the new behaviour. This parameter is not used to define a valid value. Parameter description in ProductionLabel constructor seems to not be the right one ("The lower bound on number of items to display"). This description seems closer to ClientOptions MIN_NUMBER_FOR_DISPLAYING_GOODS_COUNT.
Stock number is used to display the value when it is not negative.
I don't know exactly what it was expected but I guess there is some confusion about the meaning of the parameter.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi,
I just downloaded the nightly release for the first time, and started playing. I noticed that the production numbers now have "0+" in front of them. Is this a bug? It appears in a lot of the screenshots of bug reports, so I was wondering if it was a new feature.
Hi,
I looked for why it is displayed like this.
I found that it is a change related to [https://github.com/FreeCol/freecol/search?q=9a1bbddf79e1cbcf28d8a118bad96a1449a9667e&type=commits]: "Zero stock number is valid in ProductionLabel."
Comment of the commit seems to not match with the new behaviour. This parameter is not used to define a valid value. Parameter description in ProductionLabel constructor seems to not be the right one ("The lower bound on number of items to display"). This description seems closer to ClientOptions MIN_NUMBER_FOR_DISPLAYING_GOODS_COUNT.
Stock number is used to display the value when it is not negative.
I don't know exactly what it was expected but I guess there is some confusion about the meaning of the parameter.