FMSLogo Code

Fix typos in a comment

Add logic to evaluator() to handle when the function/expression is a number.
A number is not runnable and so should act as if the procedure is unknown.
Previously, this threw an error during treeification, but a recent bug fix made it so that treeification never throws an error.
That fix introduced a crash when executing a statement like "(2 1)" because the
downstream logic didn't handle when a number was given as a procedure.
This change restores the previous behavior of throwing a "I don't know how to" error, except that it's now recoverable.

Fix Bug #603; STOP before an unknown procedure no longer throws a "don't know how to" error.
The fix is to delay throwing the error from the treeification process to the evaluation process.

Refactoring: Rewrite EVALTEST.UNKNOWNPROCINMACROLIST to use RUNNONRECOVERABLEIDONTKNOWHOWTOTEST.
A comment says that the logic had been duplicated because RUNRESULT couldn't catch the error that was thrown.
Whatever the problem was, it's not reproducible now.

Refactoring: Change SETSCRUNCH to use flonum_arg instead of numeric_arg.
flonum_arg returns a FLONUM, which is what SETSCRUNCH wants.
It also doesn't have any side effects which change the argument list.

This is part of a larger effort to make the code base simpler by removing unneeded side effects.

Remove some misleading comments that were copied&pasted from other tests.

Add some more bad input tests for SETSCRUNCH, including the use of :erract.

Refactoring: Change setpos_helper() to accept "const FLONUM*" instead of "NODE*".
This adds type safety because NODE* can be any type, but a FLONUM* can only be a FLONUM.
This also clarifies that setpos_helper() doesn't modify its arguments, as NODE* can be modified but "const FLONUM*" can't.

Add tests for SETXYZ to the full test pass.

Fix a copy&paste error in a comment