Re: [Flightgear-devel] Introducing PBR material animations

[Fernando G. L. <fer...@gm...>]

I'm honestly quite surprised that such a small change (moving a
definition out of a header file) had such deep consequences... with so
much variability across platforms and setups. Now it compiles on
Linux/Mac but fails on Windows, and the errors seem to be completely
unrelated to OsgUtils.hxx. I guess I kicked the only remaining leg of
the table and broke the delicate balance everything was in. :)

Will try to fix ASAP.

Kind regards,
Fernando

On Fri, Jun 14, 2024 at 12:12 PM <ajt...@v-...> wrote:
>
> Good news :- I do not see the osg/CopyOp error now.
>
> Bad news :-The errors below are repeated many times:
>
> Thanks (for the good news ;) )
>
> Alan
>
> 4>ReaderWriterGLTF.cxx
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(160,17): error C2027:
> use of undefined type 'SGMatModelGroup' (compiling source file
> D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/scene/material/mat.hxx(67): message : see
> declaration of 'SGMatModelGroup' (compiling source file
> D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(159): message : while
> compiling class template member function 'void
> SGSharedPtr<SGMatModelGroup>::reset(void) noexcept' (compiling source
> file D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(91): message : see
> reference to function template instantiation 'void
> SGSharedPtr<SGMatModelGroup>::reset(void) noexcept' being compiled
> (compiling source file D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/scene/material/mat.hxx(376): message : see
> reference to class template instantiation 'SGSharedPtr<SGMatModelGroup>'
> being compiled (compiling source file
> D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(160,1): error C3861:
> 'put': identifier not found (compiling source file
> D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(160,1): warning C4150:
> deletion of pointer to incomplete type 'SGMatModelGroup'; no destructor
> called (compiling source file
> D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/scene/material/mat.hxx(67): message : see
> declaration of 'SGMatModelGroup' (compiling source file
> D:\fg\simgear\simgear\scene\material\matlib.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(160,17): error C2027:
> use of undefined type 'SGMatModelGroup' (compiling source file
> D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>D:\fg\simgear\simgear/scene/material/mat.hxx(67): message : see
> declaration of 'SGMatModelGroup' (compiling source file
> D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(159): message : while
> compiling class template member function 'void
> SGSharedPtr<SGMatModelGroup>::reset(void) noexcept' (compiling source
> file D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(91): message : see
> reference to function template instantiation 'void
> SGSharedPtr<SGMatModelGroup>::reset(void) noexcept' being compiled
> (compiling source file D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>D:\fg\simgear\simgear/scene/material/mat.hxx(376): message : see
> reference to class template instantiation 'SGSharedPtr<SGMatModelGroup>'
> being compiled (compiling source file
> D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(160,1): error C3861:
> 'put': identifier not found (compiling source file
> D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>D:\fg\simgear\simgear/structure/SGSharedPtr.hxx(160,1): warning C4150:
> deletion of pointer to incomplete type 'SGMatModelGroup'; no destructor
> called (compiling source file
> D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>D:\fg\simgear\simgear/scene/material/mat.hxx(67): message : see
> declaration of 'SGMatModelGroup' (compiling source file
> D:\fg\simgear\simgear\scene\material\makeEffect.cxx)
> 4>SGPickAnimation.cxx
>
> On 14/06/2024 10:32, Fernando García Liñán wrote:
> > Hi,
> >
> > I haven't seen your report anywhere. :/
> >
> > But yeah, I had a look at Jenkins and SG doesn't compile indeed. No
> > idea why it compiles successfully on my setup though, as the reason
> > seems to be related to OSG not linking to the new OSGUtils.cxx file
> > due to simgear/structure/* being part of SGCore and not SGScene.
> >
> > I've just pushed a commit that moves these files to
> > simgear/scene/util. I'll be paying attention to Jenkins, but please
> > let me know if the error goes away.
> >
> > Kind regards,
> > Fernando
> >
> > On Fri, Jun 14, 2024 at 12:07 AM <ajt...@v-...> wrote:
> >> Ola Fernando
> >>
> >> Have you missed my report that Simgear compilation is broken on all
> >> platforms by "OSGUtils: Move definition out of header file"?
> >>
> >> Alan