Re: [Flightgear-devel] Systematize command line options as an enable/disable flag

[Florent R. <f.r...@fr...>]

Hi,

PlayeRom Roman Ludwicki <rom...@pl...> wrote:

> For now I have no further plans for changes, unless something else comes out
> to do. For now, I have tested a couple of variants of the options I use
> myself. Unit tests also pass. It would be good if someone who is not me would
> also test their option variants a bit.

FWIW, I briefly tested the following commit with my usual options,
didn't notice any problem. I didn't read the diff, just noticed two
small things:
  - there are a few added spaces at end of line (they can be seen with
    “whitespace = red reverse” in [color "diff"] section of
    ~/.gitconfig);
  - in Options::getValueFromNextParam(), the comments seem not to have
    been updated after the introduction of simgear::optional (where they
    say “empty string”).

commit 18ac3a12db90f5eecdc5cf4f265435ee884ee8b5 (HEAD -> PlayeRom-cmdline-options-rework)
Author: Roman Ludwicki <ro...@op...>
Date:   Wed Aug 30 03:24:58 2023 +0200

    Extend command line options
    
    Values for options can be separated by both the "=" character (the old way) and a space.
    The switch options enable/disable, now have a third variant with a main name that can take the values true/false, 1/0 or yes/no. E.g., in addition to the pair of options `--enable-fullscreen` and `--disable-fullscreen`, we now also have an option `--fullscreen`, which can be used with no value (the default is enable) or with true/false, 1/0 or yes/no.
    All existing options work as before.

Regards

-- 
Florent