Re: [Flightgear-devel] Helipad thresholds

[James T. <ja...@fl...>]

> On 26 Jul 2023, at 09:37, Florent Rougon <f.r...@fr...> wrote:
> 
> In the code I' ve looked at recently, there is only
> FGAirport::readThresholdData() at
> flightgear/src/Airports/airport.cxx:636:
> 
>  for (; (runway = aRoot->getChild("runway", runwayIndex)) != NULL; ++runwayIndex) {
>    SGPropertyNode* t0 = runway->getChild("threshold", 0),
>      *t1 = runway->getChild("threshold", 1);
>    if (!t0 || !t1) {
>      throw sg_io_exception("Mis-configured runway threshold data: exactly two thresholds must be defined",
>                            sg_location{runway}, "FGAirport::readThresholdData", false);
>    }
> 
> This one seems easy to fix; I don't know if there are places elsewhere
> in the NavData code which assume that “a runway always has a
> reciprocal”.

Right, I know the the Threshold XML logic only works for double-ended runways (but it’s an easy fix) : if you look i the code for places that use FGRunway::reciprocalRunway, the question is how many do / don’t check for this returning nullptr … some do, and some … don’t …maybe?

Again I don’t know if we have > 0 single-ended runways in our actual data-sets; if we do, and they aren’t crashing the simulator, then probably it works and we are mostly good.

Kind regards,
James