Re: [Flightgear-devel] 2020.3.14

[Florent R. <f.r...@fr...>]

Hi,

Erik Hofman <er...@eh...> wrote:

>> I didn’t realise the bug existed on 2020.3 … backporting it will need some
>> care I guess, I definitely don’t want to touch the validation stuff on
>> 2020.3
>
> Maybe we're talking about something different. I meant the 'instant queue'
> code which is not that intrusive.

There are three separate things (in commit order from oldest to most
recent):

1) FG commit 60ff405efcc[1]:

    FGSoundManager: fix path handling in playAudioSampleCommand()

    - Use the complete path when performing the existence check (previously,
      only the directory part was used: bug in commit
      8853fded2953959317380e4099d43db7b2f57d4a).

    - Use the resolved path (SGPath instance) obtained from
      FGGlobals::resolve_maybe_aircraft_path() when constructing the
      SGSoundSample instance; this makes it possible to use paths starting
      with the '[addon=...]' special prefix (handled by the
      AddonResourceProvider) with FGSoundManager::playAudioSampleCommand(),
      and therefore with the 'play-audio-sample' FGCommand.

    This requires SimGear commit 8febf6b9f58e9a1919ff3 ("SGSoundSample
    constructor changes").

2) SG & FG commits that allow absolute paths to work again with
   'play-audio-sample' without reverting FG 8853fded2953959: these are
   the ones that move path validation to SimGear.

3) Erik's addition of the 'instant' queue: FG commit 5acf2e26d085b7[2]
   (the comment above FGSoundManager::playAudioSampleCommand() should be
   adapted IMO, and maybe also add the DEV_WARN message James mentioned
   when the provided queue name is missing or empty). I believe that if
   the change noted as “1)” here is backported, this FG commit
   5acf2e26d085b7 should be backportable with no problem.

Related: Hooray proposed to have one queue per add-on, and an
addons.Addon method that would implicitly use the add-on specific queue.
I'm not opposed to this, as it would allow users to mute a specific
add-on using /sim/sound/queue_name/enabled (one could also have some
generic setting of a per-queue “gain” factor using similar properties?).
However, there is for now only one 'instant' queue.

Regards

[1] https://sourceforge.net/p/flightgear/flightgear/ci/60ff405efcc8aa2e74f107a6c58d3994bc92a7e4
[2] https://sourceforge.net/p/flightgear/flightgear/ci/5acf2e26d085b7553b2387b9753e9253e8b4bff4

-- 
Florent